Repository navigation
feat(public): publish bounded fixture projection from 860bbb42 - #9
Conversation
Project the reviewed 281-file public export from private fitcheck-core commit 860bbb42e0241625051f7ecfda2d55e156b07c7a.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccee63c894
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| account_resolver: AccountResolverProtocol | None = None, | ||
| account_sessions: AccountSessionManager | None = None, | ||
| source_job_admission: SourceJobAdmission | None = None, | ||
| demo_admission: DemoAdmission | None = None, |
There was a problem hiding this comment.
When the public package is launched through its shipped fitcheck-demo command, Uvicorn resolves el.product.app:app, but build_default_app() still calls build_app(services) without constructing a DemoAdmission; a repo-wide search also finds no call to DemoAdmission.from_env(). Consequently demo_admission remains None, so the write deadline, request-size limit, session quotas, supported-source check, and source-job quotas introduced here are all bypassed in the standard runtime, even if FITCHECK_DEMO_WRITE_DEADLINE_UTC is set. Wire the environment-backed admission into the hosted entry point while preserving the intentionally unbounded local mode.
Useful? React with 👍 / 👎.
The public reference previously lacked the bounded fixture admission and source-job guards prepared for the October hosted pilot. This PR projects the reviewed public export from private
Silveroboros-dev/fitcheck-corecommit860bbb42e0241625051f7ecfda2d55e156b07c7a(tree60903bccad1359264108941414542161bdf94584) onto publicmainat76e6eb73f972a906b0d7ab6ad866de9908bba74f.The manifest-approved projection contains 281 files: 10 existing files change,
el/product/demo_admission.pyis added, and no paths are removed. It adds time and quota bounds for anonymous fixture writes, tightens job claim and source binding guards, updates the public manifest and immutable lock, and extends boundary tests. Private account session/admission adapters, governed datasets, source packs, runtime traces, credentials, and cloud deployment configuration remain outside the projection.Verification: canonical source-to-candidate boundary and candidate self-check passed; the public checkout self-check passed for all 281 files;
git diff --checkpassed. The offline public suite passed locally with 758 passed and 6 skipped, excluding the two PostgreSQL-only modules (tests/test_job_store_postgres.pyandtests/test_mcp_schema_migration_postgres.py). The six skips are optional ADK, private-source-only export, and dedicated no-SDK CI checks. CI should run its configured boundary, offline, package, and PostgreSQL lanes on this PR.This PR publishes source only. It does not deploy the application or alter the public repository's deployment settings.