Different material models for ChamberSphere - #243
Merged
Conversation
…ged files to add this new block type to be used in a circuit model
…n the maximum number of iterations is reached
…ginal test case just with new material
…based on max./min. volume and max. pressure in pv loop from Sharifi et al. 2024
…l chamber with exponential material
…erial coice in input file. Changed ChamberSphere to accomodate different materials. Changed other files to include the new ChamberSphere and SphereMaterial structure. Changed input files to use the materials.
…ere_expmat test case)
…al parameters now. All tests pass now, but not yet included test cases for closed loop and simple expmat test case
…re is tested in closed loop test case)
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
mrp089
requested changes
Aug 12, 2026
mrp089
left a comment
mrp089
left a comment
Member
There was a problem hiding this comment.
Thanks, @KatrinKoesler! A view details on splitting up passive+visco and smaller readability things.
…op) and according output file to have different C0/C1 and C2/C3 pairs
Collaborator
Author
|
I addressed all the comments, so ready to re-review! Viscosity is now back in the ChamberSphere block, so could be put into a SphereViscosity block in the future if we want to add other alternative viscosity models. |
mrp089
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different material models for ChamberSphere
Current situation
As highlighted in #240 currently the ChamberSphere has a Mooney-Rivlin material model and to change to a new material model, a new ChamberSphere would have to be implemented.
Release Notes
Testing
All tests pass
Code of Conduct & Contributing Guidelines