Repository navigation
Conversation
Renames the heading to “octal notation” and explains that each digit sums read (4), write (2), and execute (1). Refs SimonSchubert#129
|
yeah there's a few other places it needs to be changed if you grep for "binary references" (or maybe just "binary") |
Author
|
Good catch, thanks. I see "binary references" still in README.md and fastlane/metadata/android/en-US/full_description.txt, so I will switch those to octal wording and push the change to this PR. |
Renames the remaining "binary references" tip title to "octal notation" to match the updated heading in assets/tips.md. Refs SimonSchubert#129
Author
|
yeah better. I think that looks like all the ones I found? It was a while back and I'm not sure. It's certainly an improvement. |
Author
|
I grepped the branch at 6540588 for "binary ref", "via binary" and "binary representation" near chmod/permissions, and nothing permission-related is left. The remaining "binary" hits are about executables or tools like ipcalc, so I think this covers it. Thanks for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The file permissions tip calls numeric chmod modes binary, which teaches the wrong notation.
The wording confuses the underlying permission bits with their octal representation.
Summary of the fix
Renames the heading to “octal notation” and explains that each digit sums read (4), write (2), and execute (1).
Verification
namcap PKGBUILDran twice; no output or exit status is recorded.repo_lintran; no output or exit status is recorded../gradlew :composeApp:lintFix :android:lintFixran; no output or exit status is recorded.Closes #129