Add MinMaxCurvatureFlowImageFilter alternate baselines for SimpleITK#2627 - #50
Merged
blowekamp merged 1 commit intoJul 24, 2026
Conversation
…cFilters_MinMaxCurvatureFlowImageFilter_longer.1.nrrd
blowekamp
marked this pull request as ready for review
July 24, 2026 16:46
blowekamp
pushed a commit
to hjmjohnson/SimpleITK
that referenced
this pull request
Aug 28, 2026
… fix
ITK commit 2a04261664 ("BUG: Fix polar angle in MinMaxCurvatureFlowFunction
threshold", merged as InsightSoftwareConsortium/ITK#6603,
InsightSoftwareConsortium/ITK#6575 item context in #6619) fixes
MinMaxCurvatureFlowFunction::ComputeThreshold normalizing the gradient
to the stencil radius (2) instead of unit length before acos(), which
had silently selected the wrong polar angle since 2002. This changes
MinMaxCurvatureFlowImageFilter output on 3D volumes.
Add the post-fix center slices as .1.nrrd alternate baselines so the
defaults and longer tests pass with both current and fixed ITK.
Verified locally: BasicFilters.MinMaxCurvatureFlowImageFilter and
Python.MinMaxCurvatureFlowImageFilter both pass against an ITK build
containing the fix, using the corrected .1.nrrd content hashes (see
below).
Note: BinaryMinMaxCurvatureFlowFunction never calls ComputeThreshold,
so it is unaffected by ITK#6603 itself. However, it inherits
MinMaxCurvatureFlowFunction's stencil radius (2) and is therefore also
perturbed by a separate, later ITK commit, 4f0b3147be ("BUG: Decouple
CurvatureFlowFunction derivative scale from radius",
InsightSoftwareConsortium/ITK#6575 item B8), which fixes
CurvatureFlowFunction::ComputeUpdate() understating the derivative by
1/radius^2 for any subclass that repurposes GetRadius() for a larger
neighborhood, as MinMaxCurvatureFlowFunction (and by inheritance
BinaryMinMaxCurvatureFlowFunction) does. BasicFilters.
BinaryMinMaxCurvatureFlowImageFilter's defaults/longer baselines will
need their own alternates for that fix; tracked as a follow-up, not
included here.
Fixup: the defaults.1.nrrd and longer.1.nrrd content-link hashes in an
earlier revision did not match the objects actually uploaded to
SimpleITK/SimpleITKExternalData#50 (stale/transcribed hashes that
resolved on no mirror), which aborted the whole superbuild at the
ExternalData fetch step and cascaded into unrelated Java/R test
failures. Corrected to the real uploaded object hashes, confirmed
against the S3 mirror and validated locally as above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate baseline data for SimpleITK/SimpleITK#2627 (MinMaxCurvatureFlowImageFilter outputs under ITK with the 3D stencil threshold fix, InsightSoftwareConsortium/ITK#6619).
Provenance
Both
SHA512/objects were regenerated by runningBasicFilters.MinMaxCurvatureFlowImageFilter(defaults and longer tags, inputInput/RA-Float.nrrd) against an ITK main build containing the 3D threshold fix, and verified byte-identical across two runs.