Skip to content

Refactor rules and release 3.0.0 - #5

Merged
Simtel merged 1 commit into
masterfrom
3.0
Aug 25, 2026
Merged

Simtel merged 1 commit into
masterfrom
3.0

Conversation

@Simtel

@Simtel Simtel commented Aug 25, 2026

Copy link
Copy Markdown
Owner
  • Rename rules (BC break):
    • CommandClassShouldHaveCommandHandlerSeeTag (was CommandClassShouldBeHelpCommandHandlerClass)
    • EventListenerShouldHaveAsEventListenerAttribute (was EventListenerClassShouldBeIncludeAsListenerAttribute)
    • ShouldNotPhpDocReturnWhenTypeHintExists (was NotShouldPhpdocReturnIfExistTypeHint)
  • Add AbstractPhpDocRule base class, drop duplicated PHPDoc parsing
  • EventListener rule inspects node attrGroups instead of reflection
  • ShouldNotPhpDocReturnWhenTypeHintExists works on ClassMethod nodes: skip union/nullable/generic types instead of bailing out; guard IdentifierTypeNode
  • Add error identifiers (PHPStan 2.x requirement)
  • Tests fetch PhpDocParser/Lexer from the container; add regression fixture for complex types
  • Fix phpstan.neon paths so self-analysis passes at level max
  • Migrate phpunit.xml.dist to the PHPUnit 12 schema

- Rename rules (BC break):
  * CommandClassShouldHaveCommandHandlerSeeTag (was CommandClassShouldBeHelpCommandHandlerClass)
  * EventListenerShouldHaveAsEventListenerAttribute (was EventListenerClassShouldBeIncludeAsListenerAttribute)
  * ShouldNotPhpDocReturnWhenTypeHintExists (was NotShouldPhpdocReturnIfExistTypeHint)
- Add AbstractPhpDocRule base class, drop duplicated PHPDoc parsing
- EventListener rule inspects node attrGroups instead of reflection
- ShouldNotPhpDocReturnWhenTypeHintExists works on ClassMethod nodes:
  skip union/nullable/generic types instead of bailing out; guard IdentifierTypeNode
- Add error identifiers (PHPStan 2.x requirement)
- Tests fetch PhpDocParser/Lexer from the container; add regression fixture for complex types
- Fix phpstan.neon paths so self-analysis passes at level max
- Migrate phpunit.xml.dist to the PHPUnit 12 schema
@Simtel
Simtel merged commit 32eab32 into master Aug 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant