Conversation
Simtel
commented
Aug 25, 2026
Owner
- Rename rules (BC break):
- CommandClassShouldHaveCommandHandlerSeeTag (was CommandClassShouldBeHelpCommandHandlerClass)
- EventListenerShouldHaveAsEventListenerAttribute (was EventListenerClassShouldBeIncludeAsListenerAttribute)
- ShouldNotPhpDocReturnWhenTypeHintExists (was NotShouldPhpdocReturnIfExistTypeHint)
- Add AbstractPhpDocRule base class, drop duplicated PHPDoc parsing
- EventListener rule inspects node attrGroups instead of reflection
- ShouldNotPhpDocReturnWhenTypeHintExists works on ClassMethod nodes: skip union/nullable/generic types instead of bailing out; guard IdentifierTypeNode
- Add error identifiers (PHPStan 2.x requirement)
- Tests fetch PhpDocParser/Lexer from the container; add regression fixture for complex types
- Fix phpstan.neon paths so self-analysis passes at level max
- Migrate phpunit.xml.dist to the PHPUnit 12 schema
- Rename rules (BC break): * CommandClassShouldHaveCommandHandlerSeeTag (was CommandClassShouldBeHelpCommandHandlerClass) * EventListenerShouldHaveAsEventListenerAttribute (was EventListenerClassShouldBeIncludeAsListenerAttribute) * ShouldNotPhpDocReturnWhenTypeHintExists (was NotShouldPhpdocReturnIfExistTypeHint) - Add AbstractPhpDocRule base class, drop duplicated PHPDoc parsing - EventListener rule inspects node attrGroups instead of reflection - ShouldNotPhpDocReturnWhenTypeHintExists works on ClassMethod nodes: skip union/nullable/generic types instead of bailing out; guard IdentifierTypeNode - Add error identifiers (PHPStan 2.x requirement) - Tests fetch PhpDocParser/Lexer from the container; add regression fixture for complex types - Fix phpstan.neon paths so self-analysis passes at level max - Migrate phpunit.xml.dist to the PHPUnit 12 schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.