Repository navigation
Record failing role and structured detail in judgment.failure - #149
Merged
Merged
Conversation
Additive: judgment.failure = {role, kind, message, exception, http_status?,
endpoint?, model?, retryable?, turn?}. Role is set at the call site (auditor,
target, judge; system for crashes outside the three). error, error_phase and
retry/verdict behaviour are unchanged.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
agent-client-protocol 1.0.0 removed acp.helpers, which inspect-ai 0.3.288 imports, so tests/test_inspect_integration.py failed on a fresh install (12 tests). With agent-client-protocol 0.12.1 all 23 pass.
This was referenced Nov 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148.
Failed scenarios now carry
judgment.failure:role(target, auditor, judge, system) plus optionalkind,http_status,exception,endpoint,model,retryable,turn. The role is set where the exception is raised, so consumers no longer infer it. Companion to SimulaMet/SimpleAuditStudio#85.error,error_phase, retry behaviour and verdict logic are unchanged.failureis a framework-owned key, so a judge cannot forge it.kindcomes from the HTTP status or exception type only; message text is not parsed, so a bare provider-unavailable error staysunknown.SingleTurnAuditorandreframing.rejudgeset it too; repeated-scenario reps get it viarun_scenario.tests/test_failure_attribution.py; threetests/snapshots/core/*_error.jsonsnapshots only gain thefailurekey.Not verified: no real provider run (synthetic exceptions only). 11 tracing/OTLP tests fail on unmodified
devin the author's environment (aiohttpmissing).