feat(lib): lower the minimum number_of_cases threshold from 25 to 10 - #141
Merged
Conversation
The release-mode case-count gate for `applied_to_treat` edges now requires 10 cases instead of 25, so release builds retain small-cohort treatment evidence that earlier releases dropped. ### Change - **Threshold:** the `drop_low_number_of_cases` default in `src/tablassert/lib.py` moves from `25.0` to `10.0`; edges with `number_of_cases >= 10` (and nulls, as before) are kept, `< 10` dropped. - **Scope unchanged:** gating (`--release` *and* `applied_to_treat`), null handling, non-numeric tolerance, and `significance`-phase placement are untouched — only the boundary moves. - **Tests:** the boundary test now exercises 9/10/11, and `test_drop_low_number_of_cases_keeps_non_numeric_cells` uses `9` for its below-threshold row (`10` is now kept). - **Changelog:** adds an `Unreleased` / `Changed` entry to `CHANGELOG.md`. ### Testing - `uv run pytest tests/test_lib.py -k number_of_cases -q --no-cov` → `8 passed`. - `make test` → `1253 passed, 3 skipped`. - `make lint` and `uv run ruff format --check .` → all clean.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-mode case-count gate for
applied_to_treatedges now requires 10 cases instead of 25, so release builds retain small-cohort treatment evidence that earlier releases dropped.Change
drop_low_number_of_casesdefault insrc/tablassert/lib.pymoves from25.0to10.0; edges withnumber_of_cases >= 10(and nulls, as before) are kept,< 10dropped.--releaseandapplied_to_treat), null handling, non-numeric tolerance, andsignificance-phase placement are untouched — only the boundary moves.test_drop_low_number_of_cases_keeps_non_numeric_cellsuses9for its below-threshold row (10is now kept).Unreleased/Changedentry toCHANGELOG.md.Testing
uv run pytest tests/test_lib.py -k number_of_cases -q --no-cov→8 passed.make test→1253 passed, 3 skipped.make lintanduv run ruff format --check .→ all clean.