Nested Promise

[johncokos]

Slate/slate/src/App.vue

Line 68 in 0bcbf74

return fetch( `slate-users/${user.username}`, {

    Auth.currentAuthenticatedUser()
      .then(user => {
        this.signedIn = true
        this.$store.commit('createUser', user)
        return fetch( `slate-users/${user.username}`, {
          method: 'GET',
          mode: 'cors'
        })
          .then(response => response.json())
          .then(apiObject => {
            this.$store.commit('setLanguageName', apiObject.languagePref)
            this.$store.commit('setLanguageCode', allLanguages.get(apiObject.languagePref))
            this.$store.commit('setCurrentRoom', apiObject.roomId)
          })
      })
      .catch(() => this.signedIn = false)
  }

Code like the above, while it works for sure in JS is part of the reason why JS has the reputation that it does. Use the SRP when you can as you would with Java to make that a little bit cleaner.

    Auth.currentAuthenticatedUser()
      .then(user => {
        this.signedIn = true;
        this.$store.commit('createUser', user);
        return this.getUser(user.username);
      })
      .catch(() => this.signedIn = false)
  }

  // this returns a promise to the caller
  const getUser = (userName) => {
    return fetch( `slate-users/${user.username}`, {
      method: 'GET',
      mode: 'cors'
    })
    .then(response => response.json());
    .then(abiObject => this.updateUserState(apiObject));
  };

  // Pull out the update user functionality.  This function isn't tied to the promise chain
  // So ... you could call it again if things change some reason (user changes a pref)
  const updateUserState = (data) => {
      this.$store.commit('setLanguageName', data.languagePref)
      this.$store.commit('setLanguageCode', allLanguages.get(data.languagePref))
      this.$store.commit('setCurrentRoom', data.roomId)
  };