Repository navigation
[fix-runtime] Preserve DeepSeek response aliases in request journals - #13
Conversation
Persist wire-compatible schema fields and continue validating historical SDK-shaped journal responses during replay. Signed-off-by: Von <haodong.lu.me@gmail.com>
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe durable DeepSeek Responses path now serializes SDK results with aliases and validates journaled payloads by field name or alias. Tests cover current and legacy records, JSON round trips, schema aliases, and validation failures. ChangesDeepSeek response persistence
Estimated code review effort: 2 (Simple) | ~15 minutes Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Essentials by visiting https://app.coderabbit.ai/settings/billing. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Validation
tests/test_deepseek_responses_lm.py: 112 passed (run before cherry-picking the identical commit onto current main).git diff --check main...HEAD: passed.The local
.gitignoreand untracked research documents are intentionally excluded.Summary by CodeRabbit
Bug Fixes
Tests