Repository navigation
fix: declare missing dependencies in package.xml - #9
Merged
Merged
Conversation
mmmarinho
added a commit
that referenced
this pull request
Oct 30, 2026
mmmarinho
added a commit
that referenced
this pull request
Oct 30, 2026
mmmarinho
added a commit
that referenced
this pull request
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare dependencies that are actually used but missing from package.xml.
eigen; exec:rclpy,rcl_interfaces,ament_index_python,launch,launch_ros,python3-numpy,python3-scipy,python3-pyqt6,python3-pyqtgraph; documents pyqtdarkthemeVerification
xmllintvalidation againstpackage_format3.xsd: OKrosdep resolve);rosdep install --from-paths src --ignore-src -r -yover the whole sas_devel workspace: "All required rosdeps installed successfully"ghcr.io/marinholab/gazebo:jazzy:colcon build-> 15/15 packages finished (exit 0);colcon list --topological-ordershows no cyclesdqroboticsPPA/PyPI,pyqtdarkthemePyPI,bota_driverGitHub) are documented in XML comments instead of being declared as unresolvable keys (same pattern as sas_core's .deb comment)