Skip to content

fix: declare missing dependencies in package.xml - #9

Merged
mmmarinho merged 1 commit into
jazzyfrom
fix/missing-package-xml-deps
Oct 23, 2026
Merged

mmmarinho merged 1 commit into
jazzyfrom
fix/missing-package-xml-deps

Conversation

@mmmarinho

Copy link
Copy Markdown
Member

Declare dependencies that are actually used but missing from package.xml.

  • Adds eigen; exec: rclpy, rcl_interfaces, ament_index_python, launch, launch_ros, python3-numpy, python3-scipy, python3-pyqt6, python3-pyqtgraph; documents pyqtdarktheme

Verification

  • xmllint validation against package_format3.xsd: OK
  • Every added key resolves in the jazzy rosdep index (rosdep resolve); rosdep install --from-paths src --ignore-src -r -y over the whole sas_devel workspace: "All required rosdeps installed successfully"
  • Full workspace build in ghcr.io/marinholab/gazebo:jazzy: colcon build -> 15/15 packages finished (exit 0); colcon list --topological-order shows no cycles
  • Deps without any rosdep key (dqrobotics PPA/PyPI, pyqtdarktheme PyPI, bota_driver GitHub) are documented in XML comments instead of being declared as unresolvable keys (same pattern as sas_core's .deb comment)

@mmmarinho
mmmarinho merged commit cf51788 into jazzy Oct 23, 2026
2 checks passed
@mmmarinho
mmmarinho deleted the fix/missing-package-xml-deps branch October 23, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant