Update gemspec to include parslet dependency update - #65
Open
mvz wants to merge 1 commit into
Open
Conversation
yildizsc
added a commit
to socio-labs/ruby-handlebars
that referenced
this pull request
Sep 1, 2026
Ruby 4.0 reduced core cgi to a shim around cgi/escape that warns under $VERBOSE. The HTML escaper now requires cgi/escape directly - warning-free, and no external cgi gem needed. A guarded fallback keeps JRuby working, where cgi/escape does not define CGI.escapeHTML on its own. The bigger fix: the gemspec declared parslet "~> 1.6" while the Gemfile, lockfile and CI had all used parslet 2.0 since 2022. That generator drift pinned every consumer to parslet 1.8.2, unmaintained since 2020. Upstream issue SmartBear#55, submitted twice as PRs SmartBear#57 and SmartBear#65, never merged. Now "~> 2.0". Drops juwelier for a hand-maintained gemspec - it caused that drift and cannot run on Ruby 3.2+. required_ruby_version stays ">= 2.7" so no existing consumer is dropped; CI covers 2.7 through 4.0 plus JRuby, pinned to ubuntu-24.04 because no ubuntu-26.04 builds exist below Ruby 3.3. Not published to RubyGems - that name is upstream's. Consumers pin a tag: gem 'ruby-handlebars', github: 'socio-labs/ruby-handlebars', tag: '0.5.0'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parslet dependency was updated in the Gemfile but never made it to the gemspec. This fixes that.