Skip to content

ui(chrome): Make the top bar the window's title bar, with the agent toggle and Settings in it - #58

Merged
snowopsdev merged 19 commits into
mainfrom
feat/polish-browser-ui
Nov 19, 2026
Merged

snowopsdev merged 19 commits into
mainfrom
feat/polish-browser-ui

Conversation

@snowopsdev

Copy link
Copy Markdown
Member

The top bar sat under a separate macOS/Windows title bar that held nothing but the window buttons, the collapsed AI agent took a 40px column at the right edge even when unused, and nothing on screen led to Settings.

Now the top bar is the window's title bar on macOS and Windows, the agent's toggle is a button in it, and a Settings gear ends the row.

The chrome row with the agent toggle and the Settings gear, no agent rail

What changes for a user

  • Title bar (macOS, Windows): no strip above the row. The traffic lights sit inside the row's left end on macOS; the minimise, maximise and close buttons are drawn over its right end on Windows, in the row's colours. The row's free space drags the window.
  • Agent: its toggle is the spark button near the right end of the row. It shows pressed while the panel is open and carries the running/approval badge while it is closed. A closed panel takes no room, so the page reaches the window's edge.
  • Settings: the gear at the end of the row opens the Settings sheet on Account, as the command palette's "Settings" does.

Things to know

  • Windows loses its menu bar. With the title bar hidden, Alt no longer shows it. Its shortcuts keep working.
  • The minimum window width grows from 588px to 664px for the two new buttons, plus 82px on macOS and 165px on Windows for the window buttons.
  • Windows fullscreen keeps the row's end inset (Electron still reports the buttons' room). frost is only fullscreen on Windows while a page is, and then the page covers the row.
  • Linux keeps its native frame. Tiling window managers draw none, and an overlay there would add window buttons inside the window.
  • A browsed page cannot drag the window. Once the native title bar is hidden, Electron takes drag regions from page views too and has no switch for it. Each tab now gets a user style sheet (macOS and Windows only) that clears app-region on every element, standard pseudo-element and built-in control part. Known limit, recorded in the spec: a pseudo-element or control part a later Chromium adds is not covered until it is listed.
  • Every screenshot baseline is regenerated (92 images): the row is two buttons longer and the agent rail is gone.

Checks

Full CI passed on this head on macOS, Windows and Linux (run 44368463744).

Reviewed with sol-loop: 4 rounds with gpt-6.2-sol on high. Sol verdict: approved

Created with Claude Fable 5.2 in Claude Code; the lanes were written by Claude Opus 5.5 and Claude Sonnet 5.5.

🤖 Generated with Claude Code

snowopsdev and others added 19 commits November 18, 2026 10:46
…, the agent takes no room

CHROME_ROW gains 'agent-toggle' last and the window's minimum goes 588 -> 626 (one --h-control
tool, one --space-1 gap). AGENT_RAIL_WIDTH and the agent rail's sheet go; workspaceRowChrome counts
the page | agent gap only while the panel is open, and TIGHT_WORKSPACE_BELOW drops to 700
(NARROW_WINDOW's sheet 242px). The toggle is pressed while open, carries the badge while collapsed
and is where focus goes on collapse.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nel takes no room

AgentToggle (the row's last tool, pressed like the SEO sidebar's, the badge while collapsed) and
AgentPanel share one useAgentPanel held by App.tsx: main's AgentState polled once, the remembered
choice and an approval's auto-open. Collapsed, AgentPanel renders nothing, so the page column takes
the rail's 40px and its gap; collapsing focuses the row's toggle. The row's width maths count seven
tools and eight gaps (626px), the tight-gap queries move to 700px, and PageArea watches a pane
that joins the row later. --agent-rail-width is retired.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ggle too (it shares .sidebar-toggle)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the window holds it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…; two at the old 160px sheet

The window's minimum now leaves the SEO sheet 242px, so the table's narrowest form is checked in a
544px (tiled) chrome. The default-width check restores the window's own viewport after it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d Windows

Reverses "window controls and dragging stay the OS's" on the user's request.
macOS hides its title bar and keeps the traffic lights centred in the row;
Windows draws its caption buttons over the row's end in the row's colours;
Linux keeps its native frame. The row pads itself from the Window Controls
Overlay's env() variables, drags as the title bar with every control
no-drag, and the window's minimum adds chromeRowInset(platform) on top of
CHROME_MIN_CONTENT_WIDTH_PX. Values measured on CI's macOS 15 and Windows
2025 runners; Windows loses its Alt menu bar, its accelerators keep working.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…regions

boot.test: window-row-is-the-title-bar replaces window-keeps-native-controls,
title-bar-overlay-follows-the-theme, title-bar-insets, and the minimum width
per platform. chrome-grid-styles: overlay colours equal the row's tokens,
the row pads by the overlay's env() variables, and only the chrome row sets
app-region. tabs.e2e: chrome-row-is-the-title-bar, macOS
fullscreen-row-takes-the-full-width, and widths that add chromeRowInset.
The token guard reads the overlay's titlebar-area-* names as lengths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d Windows

createMainWindow() spreads titleBarWindowOptions(platform): a hidden title
bar with the traffic lights at TRAFFIC_LIGHT_POSITION on macOS, the caption
buttons' overlay in the row's colours on Windows (following nativeTheme),
nothing on Linux. The minimum width adds chromeRowInset(platform). The row
pads itself by env(titlebar-area-x/-width), keeps a 40px drag strip beside
the caption buttons, drags the window and leaves its controls no-drag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…agent takes no room

# Conflicts:
#	apps/desktop/src/renderer/styles.css
#	specs/tabs.feature.md
…nimum width goes 626 to 664

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…the numbers that follow

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n Account

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Without a native title bar Electron takes drag regions from every
WebContentsView, the tab's page view included. Each tab view now gets a
user-origin style sheet on every main-frame navigation that resolves
app-region to no-drag over the page's own.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The panel keeps its view while collapsed; reopened on Agent settings or
Chats, focus stayed on the row's toggle.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…elements, and is macOS and Windows only

Review round 2: `no-drag` made Blink send a rectangle per box, so the
sheet now sets `initial`; one rule per element and box-making
pseudo-element (shadow trees are reached by the user origin); nothing is
inserted on Linux, whose native frame ignores regions. The e2e loads a
second document by URL instead of reloading.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ls, the agent rail is gone

All 92 from Linux probe run 44356302788 (the branch with its baselines removed).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…rtCSS in the Electronegativity baseline

A universal ::first-letter rule made the pseudo-element in every block and
split its text (Windows CI: highlight-keyphrase-from-ngram drew a second
box for the heading). ::first-letter and ::marker cannot carry the property
in Chromium 156, so they are left out; ::column::scroll-marker is added.
The inserted CSS is a constant, recorded with its rationale in the
Electronegativity baseline.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… and ::picker(select)

Review round 3: a page could still set a drag region on a control part
such as ::-webkit-slider-thumb. PAGE_NO_DRAG_CONTROL_PARTS lists the 50
parts a page's sheet can reach in Chromium 156 (read from the user-agent
shadow trees over the DevTools protocol).

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T01:45:42.281388Z 5d363a2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@snowopsdev
snowopsdev merged commit b7a879e into main Nov 19, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant