Repository navigation
ui(chrome): Make the top bar the window's title bar, with the agent toggle and Settings in it - #58
Merged
Merged
Conversation
…, the agent takes no room CHROME_ROW gains 'agent-toggle' last and the window's minimum goes 588 -> 626 (one --h-control tool, one --space-1 gap). AGENT_RAIL_WIDTH and the agent rail's sheet go; workspaceRowChrome counts the page | agent gap only while the panel is open, and TIGHT_WORKSPACE_BELOW drops to 700 (NARROW_WINDOW's sheet 242px). The toggle is pressed while open, carries the badge while collapsed and is where focus goes on collapse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nel takes no room AgentToggle (the row's last tool, pressed like the SEO sidebar's, the badge while collapsed) and AgentPanel share one useAgentPanel held by App.tsx: main's AgentState polled once, the remembered choice and an approval's auto-open. Collapsed, AgentPanel renders nothing, so the page column takes the rail's 40px and its gap; collapsing focuses the row's toggle. The row's width maths count seven tools and eight gaps (626px), the tight-gap queries move to 700px, and PageArea watches a pane that joins the row later. --agent-rail-width is retired. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ggle too (it shares .sidebar-toggle) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the window holds it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…; two at the old 160px sheet The window's minimum now leaves the SEO sheet 242px, so the table's narrowest form is checked in a 544px (tiled) chrome. The default-width check restores the window's own viewport after it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d Windows Reverses "window controls and dragging stay the OS's" on the user's request. macOS hides its title bar and keeps the traffic lights centred in the row; Windows draws its caption buttons over the row's end in the row's colours; Linux keeps its native frame. The row pads itself from the Window Controls Overlay's env() variables, drags as the title bar with every control no-drag, and the window's minimum adds chromeRowInset(platform) on top of CHROME_MIN_CONTENT_WIDTH_PX. Values measured on CI's macOS 15 and Windows 2025 runners; Windows loses its Alt menu bar, its accelerators keep working. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…regions boot.test: window-row-is-the-title-bar replaces window-keeps-native-controls, title-bar-overlay-follows-the-theme, title-bar-insets, and the minimum width per platform. chrome-grid-styles: overlay colours equal the row's tokens, the row pads by the overlay's env() variables, and only the chrome row sets app-region. tabs.e2e: chrome-row-is-the-title-bar, macOS fullscreen-row-takes-the-full-width, and widths that add chromeRowInset. The token guard reads the overlay's titlebar-area-* names as lengths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d Windows createMainWindow() spreads titleBarWindowOptions(platform): a hidden title bar with the traffic lights at TRAFFIC_LIGHT_POSITION on macOS, the caption buttons' overlay in the row's colours on Windows (following nativeTheme), nothing on Linux. The minimum width adds chromeRowInset(platform). The row pads itself by env(titlebar-area-x/-width), keeps a 40px drag strip beside the caption buttons, drags the window and leaves its controls no-drag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…agent takes no room # Conflicts: # apps/desktop/src/renderer/styles.css # specs/tabs.feature.md
…nimum width goes 626 to 664 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…the numbers that follow Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n Account Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Without a native title bar Electron takes drag regions from every WebContentsView, the tab's page view included. Each tab view now gets a user-origin style sheet on every main-frame navigation that resolves app-region to no-drag over the page's own. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The panel keeps its view while collapsed; reopened on Agent settings or Chats, focus stayed on the row's toggle. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…elements, and is macOS and Windows only Review round 2: `no-drag` made Blink send a rectangle per box, so the sheet now sets `initial`; one rule per element and box-making pseudo-element (shadow trees are reached by the user origin); nothing is inserted on Linux, whose native frame ignores regions. The e2e loads a second document by URL instead of reloading. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…ls, the agent rail is gone All 92 from Linux probe run 44356302788 (the branch with its baselines removed). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…rtCSS in the Electronegativity baseline A universal ::first-letter rule made the pseudo-element in every block and split its text (Windows CI: highlight-keyphrase-from-ngram drew a second box for the heading). ::first-letter and ::marker cannot carry the property in Chromium 156, so they are left out; ::column::scroll-marker is added. The inserted CSS is a constant, recorded with its rationale in the Electronegativity baseline. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
… and ::picker(select) Review round 3: a page could still set a drag region on a control part such as ::-webkit-slider-thumb. PAGE_NO_DRAG_CONTROL_PARTS lists the 50 parts a page's sheet can reach in Chromium 156 (read from the user-agent shadow trees over the DevTools protocol). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The top bar sat under a separate macOS/Windows title bar that held nothing but the window buttons, the collapsed AI agent took a 40px column at the right edge even when unused, and nothing on screen led to Settings.
Now the top bar is the window's title bar on macOS and Windows, the agent's toggle is a button in it, and a Settings gear ends the row.
What changes for a user
Things to know
app-regionon every element, standard pseudo-element and built-in control part. Known limit, recorded in the spec: a pseudo-element or control part a later Chromium adds is not covered until it is listed.Checks
Full CI passed on this head on macOS, Windows and Linux (run 44368463744).
Reviewed with sol-loop: 4 rounds with gpt-6.2-sol on high. Sol verdict: approved
Created with Claude Fable 5.2 in Claude Code; the lanes were written by Claude Opus 5.5 and Claude Sonnet 5.5.
🤖 Generated with Claude Code