Repository navigation
ui: Polish the tab strip, new-tab page, Settings, Visibility table and Overview - #59
Open
snowopsdev wants to merge 25 commits into
Open
snowopsdev wants to merge 25 commits into
snowopsdev wants to merge 25 commits into
Conversation
… width at the minimum CHROME_ROW puts new-tab right after the tablist (its next sibling, never in its scroller). ACTIVE_TAB_MIN_WIDTH_PX (132) keeps the active tab's label readable; ADDRESS_MIN_WIDTH_PX goes 240 -> 192 so CHROME_MIN_CONTENT_WIDTH_PX stays 664. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…an aligned checklist with a meter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…croll, and compacts gated data sources and retention Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rview's summary is one card The probe table's eight columns scrolled about 1,000px sideways in the panel at every width: chips choose a crawler (those that differ marked with their counts) and a three-column table compares it with the browser. Overview's scores, counts and Highlight everything become one summary card whose rings stay beside their words under the panel's minimum. Closes the Visibility table's Left-for-later item and adds its parts to NARROW_PANEL_FITS; NARROW_PANEL_WRAPS shrinks Overview's rings instead of stacking them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ar, tighter gaps NEW_TAB_LABEL is 52px and a typical scheme and host 140-157px of --text-body: the label sits --space-1 from its x and the address text --space-2 from its badge, so both fit the 332px the window's minimum leaves. TYPICAL_ORIGIN is the yardstick; the minimum stays 664 (NARROW_WINDOW derives from it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…llows the scroll, gated data sources are one line, retention is a segmented control Account and Search Console are left out once main says this build has no service for them, and a request for either lands on the top of the sheet. The section list marks the section in view as the content scrolls. A data source whose legal gate is closed is a single line with its reason. History retention is one row with a segmented radio group. Telemetry's no-endpoint note is muted text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…an aligned checklist with a meter The start view's search field and the address bar share useAddressInput (the reducer, Enter/Escape/blur, browser.navigate as typed); the address bar keeps the new tab's focus. ADDRESS_PROMPT is the one wording. The checklist's rows are one subgrid (actions share a column and its width), stacked under the labels in a card under SETUP_CHECKLIST_COLUMNS_MIN_PX; a decorative per-item meter; Hide is a quiet chip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e tab readable The + is the tablist's next sibling: right after the last tab, pinned at the tablist's end once it scrolls, 4px from the tabs and 8px from the address bar. The active tab keeps --active-tab-room (122px at the window's minimum, never under --tab-min) and the address bar gives way only to 202px; below the minimum the active tab gives way first, so the row stays whole down to 448px. The tab's label sits --space-1 from its x and the address text --space-2 from its badge, which the minimums count on. Tests: chrome-grid-styles (new-tab-follows-the-tablist, the new variables and gaps), boot (minimum from ACTIVE_TAB_MIN_WIDTH_PX), a jsdom chrome-row-dom-order test, and tabs.e2e (new-tab-button-follows-the-last-tab, narrow-row-shares-room-with-one-tab, the new Tab order and widths). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…at 300, 360 and 664px, and Overview's summary card Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… summary is one card The probe table is chips and a three-column comparison that never scrolls sideways; canonical and robots.txt URLs wrap instead of being cut. Overview's health score, AI-readiness tile, counts and Highlight everything share one card, the rings 64px beside their words (48px under the panel's minimum, where they used to stack). The spec takes the header padding and URL wrapping found when looking at the 300px panel, and the measured position of Top issues. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… per item done Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
N items done fill the meter's first N segments, whichever items they are, so it reads as progress rather than showing gaps (items 4 and 5 done lit only the last two segments). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h Console item without a client Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…out a client Settings now leaves the Search Console section out in such a build, so the item's button opened Settings on Data sources. Progress, the meter and the all-done check count the items listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the tabs, new-tab search, Settings, Visibility and Overview Actuals from probe run 44583152843 (baselines removed; every other Linux e2e passed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cuts it Resizing from 1280px to the 664px minimum left the strip scrolled to the first tab, so a third active tab was out of view until it changed or took focus. A tab the user scrolled away stays put. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eaves or the content resizes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es or the content resizes A late gsc.watch answer that left Search Console out while it was the section in view left the list with no aria-current until the next scroll. A section asked for that is still shown stays current. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ling the active tab away Scroll events run before resize observations, so the strip's clamped scroll on narrowing marked the active tab as already cut and the resize left it out of view (seen when the tabs e2e ran after others). Escape's select() in the address field also only runs while that field still has focus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Leaving Search Console out (or the sheet growing) shortened the content and clamped its scroll; that scroll event released the pin, so a requested Telemetry gave way to History with no user input. A scroll that moves up onto the content's end is the layout's: it moves the pin instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A round of UI polish on five spots that felt unfinished:
What changes for a user
en.wikipedia.org.Things to know
chrome-grid-styles.test.tsis brittle.The decisions and the alternatives rejected for each item are in the
.feature.mdfiles:tabs,browser-polish,help,account-settings,data-sources,serp-panels,seo-sidebaranddesign-tokens.Reviewed with sol-loop: 3 rounds with gpt-6.2-sol on high. Sol verdict: approved
Created with Claude Fable 5.2 and Claude Opus 5.5 (the four lanes) in Claude Code, reviewed by GPT-6.2 Sol.
🤖 Generated with Claude Code