Implement hover and go-to-definition for /typepath::variable - #477
Open
ZeWaka wants to merge 1 commit into
Open
Conversation
ZeWaka
commented
Aug 22, 2026
| UnscopedVar(Ident), | ||
| ScopedCall(Vec<Ident>, Ident), | ||
| ScopedVar(Vec<Ident>, Ident), | ||
| /// A static var access, e.g. `/type::var` |
Contributor
Author
There was a problem hiding this comment.
I thought this made more sense than trying to infer it elsewhere, and separates out the ::var bit
| } else if let Some(typepath) = typepath_base.take() { | ||
| if kind == PropertyAccessKind::Scope { | ||
| self.annotate_precise(start..end, || { | ||
| Annotation::TypePathVar(typepath, ident.clone()) |
Contributor
Author
There was a problem hiding this comment.
Thus we can annotate only when we see the ::
| self.follow_type_path(&iter, parts.as_slice()) | ||
| { | ||
| let mut next = Some(ty); | ||
| // Search the target type and its parents for the variable. |
Contributor
Author
There was a problem hiding this comment.
needed for e.g.
/datum
var/count = 0
/obj
parent_type = /datum
/obj/proc/example()
return /obj::count
ZeWaka
marked this pull request as ready for review
August 22, 2026 05:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title - adds hover and go-to-definition for
/typepath::variablepretty short addition
Demo
Recording.2026-08-21.215326.mp4
Closes #443