fix: use flat property names in the flat REST schema - #42
Merged
Conversation
The REST schema served at /api/v2/homie/schema declared firmware-version and cloud-connection, which are the v1.0 names. This file describes the flat schema, where the migration guide records those as software-version and vendor-cloud; the rename happens at v1.0, not before. The MQTT wire profile already published the flat names, so the two halves of the simulator disagreed: consumers that build field metadata from the REST types concluded the fields did not exist while their values were arriving on MQTT. Also corrects pv and evse, which had the same leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST schema served at /api/v2/homie/schema declared firmware-version and cloud-connection, which are the v1.0 names. This file describes the flat schema, where the migration guide records those as software-version and vendor-cloud; the rename happens at v1.0, not before.
The MQTT wire profile already published the flat names, so the two halves of the simulator disagreed: consumers that build field metadata from the REST types concluded the fields did not exist while their values were arriving on MQTT. Also corrects pv and evse, which had the same leak.