SortingAnalyzer: add read_only mode (different than lazy)#4713
Open
alejoe91 wants to merge 5 commits into
Open
SortingAnalyzer: add read_only mode (different than lazy)#4713alejoe91 wants to merge 5 commits into
SortingAnalyzer: add read_only mode (different than lazy)#4713alejoe91 wants to merge 5 commits into
Conversation
SortingAnalyzer: add read_only mode (different than lazy`)SortingAnalyzer: add read_only mode (different than lazy)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #4623 (and #4709) we added a
lazymode for loading theSortingAnalyzer. This kept extension data and spike vector unmaterialized to avoid loading large arrays in memory. The lazy mode though did not allow any computation.However, lazy mode could be used also to compute extensions for large datasets (see #4703) to minimize the overall memory footprint of computations.
To make these 2 use cases separate, this PR adds a
read_onlyflag for loadingSortingAnalyzer(e.g., when loading for the GUI), which prevents any saving of extensions). Thelazymode has been extended for creating analyzers, computing, and svaing/merging/splitting.For very large datasets, one could now use this (especially in conjunction with #4703), to avoid loading large arrays in memory:
The PR also propagates the lazy argument to the parallel computation of PCA metrics.