Repository navigation
A flag shows what measures it, and hints clear AA everywhere - #14
Merged
Merged
Conversation
Segments already name their referencing flags on the edit screen — the
blast radius visible where the edit happens, not discovered in a
refusal afterwards. Flags under experiment now get the same treatment:
GET /flags/{key} carries `measured_by`, the flag page says which
experiments own its variants and why renaming one mid-run hurts, and
the danger zone explains the delete it no longer offers instead of
offering one that would 409.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
.hint wore --text-subtle, which clears 4.5:1 on cards but lands at 4.37:1 on the sunken preview panel and card footers. Muted instead; the hierarchy step below body text survives in the font size. Found by running axe against the flag detail page for the first time — every earlier pass had audited other screens. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
One pass over a fresh seed, as always. flag-rules.png now also shows the measured-by callout on the seeded flag. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the visibility loop the experiments feature opened. Segments already name their referencing flags on the edit screen — this repo's stated principle that the blast radius should be visible where the edit happens. Flags under experiment now get the same treatment:
GET /flags/{key}returnsFlagWithUsage(flattened, additive):measured_bylists the experiments whose arms are this flag's variants, asenvironment/key, in any lifecycle state — a draft still pins deletion and its counters still name the variants.Along the way, the first axe pass ever run against the flag detail page caught a real pre-existing AA miss:
.hinton sunken surfaces (the preview panel, card footers) sat at 4.37:1. Hints now wear--text-muted; the hierarchy step survives in the font size. That recolours hints everywhere, so the whole gallery is regenerated in one pass, per house rule.Verified in a real browser: the pinned flag shows the callout and no delete button, an unmeasured flag shows neither, and axe reports zero WCAG A/AA violations on both.
🤖 Generated with Claude Code