Skip to content

Allow reasonable CLIENT commands to proceed without admin mode enabled#3129

Open
mgravell wants to merge 2 commits into
mainfrom
marc/client-admin
Open

Allow reasonable CLIENT commands to proceed without admin mode enabled#3129
mgravell wants to merge 2 commits into
mainfrom
marc/client-admin

Conversation

@mgravell

@mgravell mgravell commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

fix #3127 fix #3128

  • Historically, CLIENT was considered an admin command (because of CLIENT KILL, CLIENT PAUSE, etc)
  • For most 1st party commands, we set an internal flag to say "we know what we're doing, this is fine"
  • A quirk of Execute(...) < 3.x means that it didn't actively search for admin commands
  • In 3.0, Execute(...) got smarter, and correctly identifies CLIENT usage

Here, we add logic to detect the sub-command - for now, only necessary for Execute(...), but potentially it is versatile enough to use with other command types.

We've also done an audit of the remaining commands (#3128) - it turns out that a small number of the CLIENT ones are probably all we'd want to handle. Other combinations are still explicitly disabled; new tests assert:

  • that the expected subcommands: work
  • that other subcommands: do not work
  • that AddLibraryNameSuffix works (which we verify by issuing a GETNAME)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review "admin mode" commands and filter by sub-commands [3.0.x] Known Behavior Change (Admin Command), but cannot trace back reason

1 participant