program not valid with latest three.js

[aiden-jeffrey]

I'm seeing this error trying to use your library on a recent three.js release (r157):

three.module.js:19999 THREE.WebGLProgram: Shader Error 0 - VALIDATE_STATUS false

Program Info Log: Fragment shader is not compiled.
�

FRAGMENT

ERROR: 0:1591: 'GeometricContext' : undeclared identifier
ERROR: 0:1591: 'geometry' : syntax error
�

  1586: 	material.alphaT = mix( pow2( material.roughness ), 1.0, pow2( material.anisotropy ) );
  1587: 	material.anisotropyT = tbn[ 0 ] * anisotropyV.x - tbn[ 1 ] * anisotropyV.y;
  1588: 	material.anisotropyB = tbn[ 1 ] * anisotropyV.x + tbn[ 0 ] * anisotropyV.y;
  1589: #endif
  1590: 
> 1591: GeometricContext geometry;
  1592: 
  1593: geometry.position = - vViewPosition;
  1594: geometry.normal = normal;
  1595: geometry.viewDir = ( isOrthographic ) ? vec3( 0, 0, 1 ) : normalize( vViewPosition );
  1596: 
  1597: #ifdef CLEARCOAT

Any idea what I can do to fix this? Should I just use the version of this that ships with three.js?

[aiden-jeffrey]

Looks like this was the PR that broke things: mrdoob/three.js#26805

[aiden-jeffrey]

I didn't want to use the three.js version mainly because they don't expose lightColor in the constructor.

[aiden-jeffrey]

Had a stab at applying that diff to your shader: #40

[Sceat]

@aiden-jeffrey your fork doesn't seem to work for me in three 159, running this fails

 npm i aiden-jeffrey/three-csm#aiden/three-157

[tolgaand]

any updates?

[aiden-jeffrey]

any updates?

I just used the three.js fork of this in the end. I'm sure that the PR I linked is most of the way there, but I couldn't get the shadows to render.

[ebeaufay]

I'm sure that the PR I linked is most of the way there, but I couldn't get the shadows to render.

Just tried your fix with three.js 162 and I do have shadows!

[dawidsmuga]

I'm sure that the PR I linked is most of the way there, but I couldn't get the shadows to render.

Just tried your fix with three.js 162 and I do have shadows!

How you did it? I mean three-csm working with three 162.

I have this problem.

[ebeaufay]

How you did it? I mean three-csm working with three 162.

I forked CSM (actually just copied the files from the threejs samples: CSM.js, CSMFrustum.js and CSMShader.js)
Then I applied the fix from @aiden-jeffrey and I use my local version of CSM for now.

The file with the fix is here: https://github.com/ebeaufay/UltraGlobe/blob/master/src/csm/CSMShader.js

[qing-nv]

How you did it? I mean three-csm working with three 162.您是怎么做到的？我的意思是 three-csm 与三个 162 一起工作。

I forked CSM (actually just copied the files from the threejs samples: CSM.js, CSMFrustum.js and CSMShader.js)我分叉了 CSM（实际上只是从 threejs 示例中复制了文件：CSM.js、CSMFrustum.js 和 CSMShader.js） Then I applied the fix from @aiden-jeffrey and I use my local version of CSM for now.然后我应用了修复程序，现在使用我的本地版本的 CSM。

The file with the fix is here: https://github.com/ebeaufay/UltraGlobe/blob/master/src/csm/CSMShader.js

目前链接访问不了，方便告诉我您修改哪里嘛？

[ebeaufay]

this is fixed in the samples of the latest versions of three.js. if you're using an older version of three.js, I guess you'll need to go through the chang-logs to see what the fix was