Skip to content

feat(server): configure an explicit request body limit - #430

Merged
Ashborne267 merged 1 commit into
StreamGive:mainfrom
mayborn005:fix/issue-353
Oct 27, 2026
Merged

Ashborne267 merged 1 commit into
StreamGive:mainfrom
mayborn005:fix/issue-353

Conversation

@mayborn005

Copy link
Copy Markdown
Contributor

Summary

  • Set an explicit 1 MiB default request-body limit, configurable with positive-integer BODY_LIMIT_BYTES.
  • Enforce the limit while capturing raw request bodies and preserve the standard 413 { "error": "payload_too_large" } response.
  • Document the environment variable and add tests for oversized payloads and invalid configuration.

This is a dedicated assignee-authored PR for #353. The broader open PR #391 also references this issue.

Validation: git diff --check passed. Local Vitest could not run because dependencies are not installed (vitest: command not found).

Closes #353.

@zeemscript

Copy link
Copy Markdown
Contributor

Hi @Ashborne267 — I rebased PR #430 onto the current base and resolved the conflicts; GitHub now reports it mergeable. The safety check passes. The fresh Lint, typecheck, test workflow still fails on the current base in unrelated files, including unused declarations in src/notifications/service.ts, src/routes/streams.ts, and src/server.ts. src/routes/streams.ts currently contains placeholder route stubs, so I left that broader upstream issue outside this request-size-limit PR. Could you take a look at the base workflow failure?

@Ashborne267
Ashborne267 merged commit 333cfca into StreamGive:main Oct 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure and document a request body size limit

3 participants