JVNAUTOSCI-2690: Make direct-message sends prompt and idempotent - #475
Merged
Merged
Conversation
| def test_is_authoritative_workflow_concept_id_fails_open( | ||
| monkeypatch: pytest.MonkeyPatch, | ||
| ) -> None: | ||
| import src.backend.services.workflow_capability_service as capability_service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — direct-message sends now give immediate pending feedback, converge to one durable effect across retries, and remain bound to the actor-owned tab organisation.
User outcome
A user can send or retry a reply or new direct message without an inert-looking UI, accidental duplicate delivery, or cross-tab organisation leakage. This repairs the real Messages incident documented in JVNAUTOSCI-2690.
Material changes
Jira: https://naoinstitute.atlassian.net/browse/JVNAUTOSCI-2690
Evidence
Ship boundary