JVNAUTOSCI-2234: Render promoted summary fields and full literals - #477
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge decision: ready — merging makes long relationship literals fully inspectable and copyable, and lets Vontology type policy promote arbitrary fields into the concept summary without changing KCAP salience.
User outcome
A concept-tab user can read and copy the complete text behind a truncated relationship value. Types can also use rendering-specific
#V#has_summary_fieldspolicy to place important exact values beside the description at the top of the concept page.Material changes
#V#research_description→#V#summary_field_research_description_as_of→#V#has_research_description_as_of; this is explicitly rendering policy and does not alter KCAP salience.Evidence
.venv/bin/pytest -q tests/backend/test_concept_summary_field_resolver.py tests/backend/test_concept_summary_renderer_service.py tests/backend/test_concept_summary_renderer_routes.py— 25 passed.dynamicTabs.js.origin/mainworktree reproduced the same 9/9 failures, establishing them as baseline rather than candidate-caused.Ship boundary