Repository navigation
security(ci): disable persisted checkout credentials in read-only workflows - #497
Open
abojeEdwin wants to merge 2 commits into
Open
abojeEdwin wants to merge 2 commits into
abojeEdwin wants to merge 2 commits into
Conversation
|
@abojeEdwin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
This covered all checkout steps when opened, but it no longer satisfies “every” workflow on current |
…kflows - Add persist-credentials: false to all actions/checkout steps - Add comment explaining downstream steps do not push - Prevents GitHub token from being left in Git credential config - Affects workflows: bindings-check, contract, coverage, docs-links - No changes to checkout depth or existing job behavior Fixes Sub-Rosa-Issue#490
- Rebase on latest main to pick up web.yml, env-examples.yml, line-lengths.yml - Add persist-credentials: false + comment to the 3 new workflows - Add scripts/check-workflow-credentials.mjs as a repository-wide assertion that every actions/checkout step disables credential persistence - Wire wf-creds:check into the coverage workflow so future regressions fail CI - Add unit tests covering pass, fail, partial, and empty cases Fixes Sub-Rosa-Issue#490
abojeEdwin
force-pushed
the
security/disable-checkout-credentials-490
branch
from
October 23, 2026 00:41
8b444d7 to
738da53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490