Skip to content

security(ci): disable persisted checkout credentials in read-only workflows - #497

Open
abojeEdwin wants to merge 2 commits into
Sub-Rosa-Issue:mainfrom
abojeEdwin:security/disable-checkout-credentials-490
Open

abojeEdwin wants to merge 2 commits into
Sub-Rosa-Issue:mainfrom
abojeEdwin:security/disable-checkout-credentials-490

Conversation

@abojeEdwin

Copy link
Copy Markdown

Closes #490

  • Add persist-credentials: false to all actions/checkout steps
  • Add comment explaining downstream steps do not push
  • Prevents GitHub token from being left in Git credential config
  • Affects workflows: bindings-check, contract, coverage, docs-links
  • No changes to checkout depth or existing job behavior

@drips-wave

drips-wave Bot commented Oct 21, 2026

Copy link
Copy Markdown

@abojeEdwin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin

Copy link
Copy Markdown
Collaborator

This covered all checkout steps when opened, but it no longer satisfies “every” workflow on current main: web.yml, env-examples.yml, and line-lengths.yml also use checkout without persist-credentials: false. Please rebase and add the same setting/comment to all seven current checkout steps, plus a focused repository-wide assertion so later workflows cannot regress.

…kflows

- Add persist-credentials: false to all actions/checkout steps
- Add comment explaining downstream steps do not push
- Prevents GitHub token from being left in Git credential config
- Affects workflows: bindings-check, contract, coverage, docs-links
- No changes to checkout depth or existing job behavior

Fixes Sub-Rosa-Issue#490
- Rebase on latest main to pick up web.yml, env-examples.yml, line-lengths.yml
- Add persist-credentials: false + comment to the 3 new workflows
- Add scripts/check-workflow-credentials.mjs as a repository-wide assertion
  that every actions/checkout step disables credential persistence
- Wire wf-creds:check into the coverage workflow so future regressions fail CI
- Add unit tests covering pass, fail, partial, and empty cases

Fixes Sub-Rosa-Issue#490
@abojeEdwin
abojeEdwin force-pushed the security/disable-checkout-credentials-490 branch from 8b444d7 to 738da53 Compare October 23, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security(ci): disable persisted checkout credentials in read-only workflows

2 participants