Skip to content

feat: comprehensive fixes for issue #489 - seal round commit window, … - #508

Closed
sulaimonifeoluwa4-blip wants to merge 1 commit into
Sub-Rosa-Issue:mainfrom
sulaimonifeoluwa4-blip:fix/issue-489
Closed

sulaimonifeoluwa4-blip wants to merge 1 commit into
Sub-Rosa-Issue:mainfrom
sulaimonifeoluwa4-blip:fix/issue-489

Conversation

@sulaimonifeoluwa4-blip

Copy link
Copy Markdown

Closes #489

…escrow conservation, and SDK improvements

  • Add ROUND_CONTRACT_ERRORS constant with seal round error codes (40, 41, 42)
  • Add ROUND_CONTRACT_ERRORS_BY_NAME mapping
  • Add diffContractErrorMapping and getRoundContractError functions
  • Add isRoundContractErrorRetryable function with retryable codes
  • Add SubRosaPaginationError class
  • Fix mainnet-micro.ts: add assertMainnetConfirmed/assertReadinessForExecute imports, revealRound field
  • Fix client.ts: add SdkRoundAssetConfig, session/binding fields, cursor handling
  • Fix client.test.ts: add readFileSync, update imports, test expectations
  • Fix conservation.ts cursor handling (pre-existing type errors)
  • Fix seal.ts: add assertSealRoundWindow, make sealRound optional
  • Fix seal-fixture.ts: add valid contract IDs, revealRound
  • Fix network.test.ts: add passphrase mismatch tests
  • Fix errors.test.ts: use Object.entries, add type casts
  • Fix conservation.test.ts: update next_cursor handling

…ommit window, escrow conservation, and SDK improvements

- Add ROUND_CONTRACT_ERRORS constant with seal round error codes (40, 41, 42)
- Add ROUND_CONTRACT_ERRORS_BY_NAME mapping
- Add diffContractErrorMapping and getRoundContractError functions
- Add isRoundContractErrorRetryable function with retryable codes
- Add SubRosaPaginationError class
- Fix mainnet-micro.ts: add assertMainnetConfirmed/assertReadinessForExecute imports, revealRound field
- Fix client.ts: add SdkRoundAssetConfig, session/binding fields, cursor handling
- Fix client.test.ts: add readFileSync, update imports, test expectations
- Fix conservation.ts cursor handling (pre-existing type errors)
- Fix seal.ts: add assertSealRoundWindow, make sealRound optional
- Fix seal-fixture.ts: add valid contract IDs, revealRound
- Fix network.test.ts: add passphrase mismatch tests
- Fix errors.test.ts: use Object.entries, add type casts
- Fix conservation.test.ts: update next_cursor handling
@sulaimonifeoluwa4-blip
sulaimonifeoluwa4-blip deleted the fix/issue-489 branch October 23, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security(high/easy): enforce SHA-pinned and allowlisted GitHub Actions

2 participants