Repository navigation
ci(high/easy): fail when generated bindings dirty the worktree - #554
Open
CemAyyildiz wants to merge 1 commit into
Open
CemAyyildiz wants to merge 1 commit into
CemAyyildiz wants to merge 1 commit into
Conversation
Adds a git diff --exit-code step to bindings-check.yml immediately after pnpm bindings:check, so any unexpected drift in a tracked, generated file is visible and blocking in CI, not just the specific index.ts comparison bindings:check already performs on its own. Documented in docs/CI.md next to the existing coverage gate. Closes Sub-Rosa-Issue#525
Collaborator
|
Doğrudan merge denendi; ancak GitHub güncel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #525
What
Adds a
git diff --exit-codestep to.github/workflows/bindings-check.yml, immediately after the existingpnpm bindings:checkstep.Why
bindings:checkalready diffs the freshly generatedindex.tsagainst the committed one and fails on a mismatch, but that only covers that one file. This adds a broader, blocking assertion that the whole worktree is clean after the bindings check runs, so any other unexpected generated-file drift surfaces in CI instead of silently landing inmain.Docs
Documented in
docs/CI.mdunder a new "Bindings worktree cleanliness gate" section, next to the existing coverage gate writeup.Scope
CI config + docs only — no change to
bindings:checkitself, the bindings generation logic, or any other workflow.