Repository navigation
ci(high/easy): enforce the direct-time-access guard - #582
Open
umpireboulianne-design wants to merge 1 commit into
Open
umpireboulianne-design wants to merge 1 commit into
umpireboulianne-design wants to merge 1 commit into
Conversation
Wire time:guard:test and time:guard into CI, use cross-platform fileURLToPath in check-direct-time-access.mjs, add CI wiring assertion in check-direct-time-access.test.mjs, and document in docs/CI.md. Fixes Sub-Rosa-Issue#522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforces
time:guard:testandtime:guard(scripts/check-direct-time-access.test.mjsandscripts/check-direct-time-access.mjs) in CI so new direct wall-clock or timer access (Date.now,new Date,setTimeout,setInterval,clearTimeout,clearInterval) cannot bypass@sub-rosa/time.Fixes #522
Closes #522
Changes
package.json: Wirecheck-direct-time-access.test.mjsandcheck-direct-time-access.mjsinto the CI check suite (coverage:test).scripts/check-direct-time-access.mjs: UsefileURLToPath(new URL("..", import.meta.url))for cross-platform path resolution and keep existing allowlisted paths explicit so new direct clock access fails CI.scripts/check-direct-time-access.test.mjs: Add an automated test assertingtime:guard:testandtime:guardCI wiring and documentation.docs/CI.md: Document the direct time-access guard and local commands (pnpm time:guard:test,pnpm time:guard).