Repository navigation
feat(sockets): message delivery guarantees + offline queue - #300
Merged
Merged
Conversation
Collaborator
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147
Adds at-least-once delivery guarantees for driver-bound socket messages in
src/sockets/messageQueue.ts:SOCKET_MESSAGE_QUEUE_MAX, default 100) with oldest-first eviction.SOCKET_MESSAGE_MAX_RETRIES(default 5) automatic re-deliveries after ACK timeouts; exhausted messages stay queued for the next reconnect flush.flush()re-delivers each unacked message exactly once, so a reconnecting driver never gets duplicates.New env knobs documented in
.env.example/src/config/env.ts(validated).socket.service.tswired to the new callbacks.Tests:
tests/messageQueue.test.ts— 17 pass (queued until ACK, ACK removal, reconnect flush without duplicates, ACK-timeout retry, queue bound/eviction, per-driver isolation).Run:
npx jest tests/messageQueue.test.ts --runInBand --forceExit.