Repository navigation
ci: run the verification block on push and PR - #5
Merged
Merged
Conversation
Linux job: py_compile, unittest discover, both Node smoke scripts. Windows job runs the collector suite, which is where the Win32 ctypes backend executes; on Linux those two test_hostinfo.py tests are platform gates and never run.
wintypes.LARGE_INTEGER has no .quad; the ctypes accessor is .value. EnumProcesses is exported by psapi, not kernel32, so the lookup raised AttributeError on the runner and processes() never ran. Both Windows tests now execute on the CI windows job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the AGENTS.md verification block on push to
mainand on pull requests. No build step, no dependencies; the workflow calls the commands the repo already documents.Two jobs:
py_compile,unittest discover,smoke/ui-primitives.mjs,smoke/shell.mjs.test_hostinfo.pytests are platform gates and never run, so that path was read and not executed anywhere.The first run failed, and it found two real bugs in
collector/hostinfo.py.wintypes.LARGE_INTEGERhas no.quad. On Windows it resolves toc_longlong, whose accessor is.value, so_win_cpu_times()raisedAttributeError: 'c_longlong' object has no attribute 'quad'. Fixed to.value.EnumProcessesis exported by psapi, not kernel32._kernel32.EnumProcessesraisedAttributeError: function 'EnumProcesses' not foundon the runner, soprocesses()returned nothing. Fixed to_psapi.EnumProcesses.Both fixes sit on this branch so the windows job verifies them.
Local check before pushing:
py_compileclean, 86 tests with 3 platform skips, both smoke scripts ALL PASS. Three repeat runs came back clean; the run right after the edit showed one failure, so expect an occasional flake from the tests that make real HTTP calls against the stub servers.