Skip to content

Show the next weekly reward on the activity points icon - #79

Merged
Drefvelin merged 2 commits into
mainfrom
next-reward-lore
Sep 29, 2026
Merged

Drefvelin merged 2 commits into
mainfrom
next-reward-lore

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The weekly activity points icon names the next reward, including each possible draw when that milestone pays from a pool.
  • Once every milestone for the week is claimed, that icon says there are no more rewards this week.

Test plan

  • mvn test passes, including lore cases for a fixed reward, a multi-entry pool, a claimable reward, and a finished week.
  • Load the jar on TFMCDev and open /activity with points below the next milestone, at a claimable milestone, and after the last milestone is claimed.

Summary by CodeRabbit

  • New Features
    • The weekly activity bar shows the next milestone reward, including item amounts or available reward options, alongside the points needed to reach it.
    • When rewards are ready to claim, the bar displays the available rewards and a claim prompt.
    • When no further rewards remain this week, the bar displays a dedicated message.

Players can see which reward is next, including each possible pool draw, and the icon says there are no more rewards this week once every milestone is claimed.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1a576768-4ca6-4abc-b892-85c666602c48

📥 Commits

Reviewing files that changed from the base of the PR and between e80614d and 4437728.

📒 Files selected for processing (1)
  • src/test/java/net/tfminecraft/activitytf/config/ActivityConfigurationRewardsTest.java
 _________________________________________
< OODA Loop: Observe, Orient, Debug, Act. >
 -----------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 74958de1-b5e0-430e-84a6-5840840e74df

📥 Commits

Reviewing files that changed from the base of the PR and between 0c6d158 and e80614d.

📒 Files selected for processing (4)
  • src/main/java/net/tfminecraft/activitytf/gui/ActivityGui.java
  • src/main/resources/messages.yml
  • src/test/java/net/tfminecraft/activitytf/config/DefaultResourcesTest.java
  • src/test/java/net/tfminecraft/activitytf/gui/ActivityGuiTest.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The weekly activity bar now shows details for the next milestone reward, available reward options, and claimable rewards. Its messages distinguish between a next reward, multiple reward options, and no remaining rewards.

Changes

Weekly reward lore

Layer / File(s) Summary
Reward lore calculation and validation
src/main/java/net/tfminecraft/activitytf/gui/ActivityGui.java, src/main/resources/messages.yml, src/test/java/net/tfminecraft/activitytf/config/DefaultResourcesTest.java, src/test/java/net/tfminecraft/activitytf/gui/ActivityGuiTest.java
The activity bar displays the next reward or its options, along with a claim prompt when rewards are due. Message keys and tests cover next rewards, pool options, and the no-rewards state.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to e8061

This change only alters the lore text on the weekly activity icon. No actionable merge-blocking risk remains, though the planned in-game check is still unchecked.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: displaying the next weekly reward on the activity points icon. It also aligns with the added handling for reward pools and completed weekly m…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the weekly bar,
And spots the prizes near and far.
One reward, or options on display,
A claim prompt joins the path today.
No more rewards? The bar will say.

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 29, 2026
CI was missing lines that java.util.logging handlers did not record, so those assertions failed even though the warnings were printed.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Drefvelin
Drefvelin merged commit 7b73655 into main Sep 29, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the next-reward-lore branch September 29, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant