Show the next weekly reward on the activity points icon - #79
Conversation
Players can see which reward is next, including each possible pool draw, and the icon says there are no more rewards this week once every milestone is claimed. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe weekly activity bar now shows details for the next milestone reward, available reward options, and claimable rewards. Its messages distinguish between a next reward, multiple reward options, and no remaining rewards. ChangesWeekly reward lore
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change only alters the lore text on the weekly activity icon. No actionable merge-blocking risk remains, though the planned in-game check is still unchecked. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 11 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit checks the weekly bar, Comment |
CI was missing lines that java.util.logging handlers did not record, so those assertions failed even though the warnings were printed. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Test plan
mvn testpasses, including lore cases for a fixed reward, a multi-entry pool, a claimable reward, and a finished week./activitywith points below the next milestone, at a claimable milestone, and after the last milestone is claimed.Summary by CodeRabbit