Skip to content

fix: reword player messages in character - #23

Merged
ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording
Oct 1, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
copy/rp-wording

Conversation

@ryanbarlow97

Copy link
Copy Markdown
Contributor

Summary

Rewords player-facing gameplay messages that broke immersion with server terms (permissions, access, containers, entities, chunks, plugin names) so they read in character. Staff and admin commands, usage help and setup errors keep their plain wording. Wording only: no permission checks or message routing change.

Before and after

Colour codes are omitted; the code keeps them.

Before After
It cannot be unpicked in this version. Once signed, it cannot be unpicked.
No player with that name has joined this server. No one by that name is known here.

Testing

mvn -o verify passes: 684 tests, 0 failures.

🤖 Generated with Claude Code

Replace out-of-character wording in gameplay messages (permissions,
containers, entities, chunks, plugin tags) with in-world phrasing.
Staff commands, usage help and setup errors keep their plain wording.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 0df80837-59cc-4e0e-9c18-a0d66a8a87c0

📥 Commits

Reviewing files that changed from the base of the PR and between 70cb747 and d591171.

📒 Files selected for processing (3)
  • src/main/java/net/tfminecraft/archaeo/establish/CampIdentifyBoard.java
  • src/main/java/net/tfminecraft/archaeo/establish/CampListener.java
  • src/test/java/net/tfminecraft/archaeo/establish/CampListenerTest.java

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Updates
    • Clarified that signed offer books cannot be unpicked.
    • Updated the message shown for unknown player names during invitations; the invitation remains pending so another name can be entered.

Walkthrough

Two player-facing messages change: offer-book lore and the response to unknown invite names. Invite tests now expect the updated response for unknown and blank names.

Changes

Offer book lore

Layer / File(s) Summary
Update offer-book lore
src/main/java/net/tfminecraft/archaeo/establish/CampIdentifyBoard.java
The final lore line now says a reading cannot be unpicked once signed. It replaces the previous version-qualified wording.

Unknown-player invite response

Layer / File(s) Summary
Update unknown-player response
src/main/java/net/tfminecraft/archaeo/establish/CampListener.java, src/test/java/net/tfminecraft/archaeo/establish/CampListenerTest.java
The response for an unknown name changes to “No one by that name is known here.” The invitation remains pending. Tests for unknown and blank names expect the new response.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d5911

The text updates clarify offer-book signing and unknown invitees without an established change to gameplay behavior. No material merge risk remains in the reviewed changes.

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit ad40ad2 into main Oct 1, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the copy/rp-wording branch October 1, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant