Skip to content

Fix Chihuahua and Yorkshire textures and eyebrow geometry - #38

Merged
Nowkoo merged 1 commit into
mainfrom
fix/pet-model-mipmaps
Oct 10, 2026
Merged

Nowkoo merged 1 commit into
mainfrom
fix/pet-model-mipmaps

Conversation

@Nowkoo

@Nowkoo Nowkoo commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Adds the confirmed editable Chihuahua and Yorkshire ModelEngine blueprints and their installation instructions. Their embedded textures now use 80 × 112 pixels with a 40 × 56 UV canvas, removing these two textures' mipmap-size warnings. Yorkshire includes the eyebrow corrections saved in Blockbench.

Validation: both blueprints match the owner's saved files by SHA-256; embedded PNG dimensions and UV dimensions were checked; all eleven animation clips and bone definitions match the deployed models (apart from the editor's selected-animation flag). This change updates assets and documentation only and does not require a new CompanionPets JAR or a server restart.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 82c903a5-4ae4-4f84-9b51-dd350bb7f3fd

📥 Commits

Reviewing files that changed from the base of the PR and between 892053d and 35157ab.


📒 Files selected for processing (4)
  • README.md
  • models/modelengine/companions/README.md
  • models/modelengine/companions/chihuahua.bbmodel
  • models/modelengine/companions/yorkshire.bbmodel

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added links to editable Chihuahua and Yorkshire ModelEngine blueprints, with details about their animations, textures, UV dimensions and mipmap compatibility.
    • Documented corrected textures and Yorkshire eyebrow geometry, plus instructions for installing the assets and rebuilding the pack.
    • Clarified that applying the assets does not require a CompanionPets update or server restart.

Walkthrough

The README files now link to and describe editable Chihuahua and Yorkshire ModelEngine blueprints. They document asset characteristics, installation steps, pack rebuilding, and the location of generated resources and checksums.

Changes

Companion blueprints

Layer / File(s) Summary
Blueprint links and installation instructions
README.md, models/modelengine/companions/README.md
The main README links to the editable blueprints. The model directory README describes their assets, installation steps, pack rebuilding, and generated resource location.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: ryanbarlow97


Merge Risk: ⚪ Minimal · up to 35157

No verified issue blocks merging. The configured model IDs’ runtime resolution remains unconfirmed because ModelEngine’s import-key behavior is unknown.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Nowkoo

Nowkoo commented Oct 10, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@Nowkoo
Nowkoo merged commit 9993617 into main Oct 10, 2026
2 checks passed
@Nowkoo
Nowkoo deleted the fix/pet-model-mipmaps branch October 10, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant