Fix direct console logging warnings

[ryanbarlow97]

Paper reports Dowsing for writing directly to System.out during startup. Route biome and restored production-method messages through the plugin logger. Resource-file read failures now use warning log records with the original exception attached.

Validation: Java 21 Maven clean verify passed (29 tests), runtime JAR verification passed, and the source scan found no active System.out/System.err calls. Live server validation has not been performed.

Summary by CodeRabbit

• Improvements
  • Biome configuration details and active slot information are now recorded in application logs rather than printed to the console.
  • Missing resource files now generate warning logs that include the affected file and error details.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7d4487e6-d6cc-4fd7-8d7f-d3a6e088d802

📥 Commits

Reviewing files that changed from the base of the PR and between 1adee0f and 37360cf.

📒 Files selected for processing (2)

• src/main/java/net/tfminecraft/dowsing/objects/NodeType.java
• src/main/java/net/tfminecraft/dowsing/utils/Database.java

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

NodeType and Database now send selected messages through the plugin logger. Database logs resource-open failures as warnings that include the file path and exception.

Changes

Plugin Logger Updates

Layer / File(s)	Summary
Log configured biomes src/main/java/net/tfminecraft/dowsing/objects/NodeType.java	When biomes is configured, NodeType logs the biome list through the plugin logger.
Log database diagnostics src/main/java/net/tfminecraft/dowsing/utils/Database.java	Resource-open failures are logged as warnings with the file path and exception. setSlots logs the active PM ID through the plugin logger.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 37360

This change redirects biome and database diagnostics to the plugin logger. The available context shows no remaining behavior issue that needs resolution before merge.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 37360

Normal startup initializes the plugin before the new logger calls run, and the resource and restoration paths retain their existing inputs and controls. A public node-type constructor now depends on plugin initialization; its use by callers outside this repository is unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The changed sink is the plugin's server-side logger. The inspected changes show no new cross-service authority or player-controlled filesystem path; runtime log distribution and retention remain unknown.

Trust Boundaries and Controls

• observed — The resource APIs retain their chunk input and fixed-directory scan. The logger substitution does not add an authorization decision or grant the caller a new file-selection capability.

Resilience and Maintainability Implications

• inferred — Plugin initialization precedes the repository's configured-type construction path. Pre-enable construction by an external caller remains an unresolved availability scenario, not an established attack path.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: replacing direct console output with plugin logging and improving warning messages.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

_{I’m a rabbit, ears alert,
I hear the logger, not stdout.
Biomes hop into the log,
File warnings leave a trail,
PM IDs join the evening glow.}

_{Comment @coderabbitai help to get the list of available commands.}