Repository navigation
Lures: a restart is harmless and only a saved death settles - #16
Conversation
Shutdown recorded every committed player as departing, so anyone not back within logout-grace-seconds of the stop owed a death. A restart is now ignored again: the empty lure fails without penalty, as before 0.3.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
size:S
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to Restarts no longer record online players as departures, while shutdown still saves infestation state. No actionable merge risk is established by the reviewed changes.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
The DEATH session end fires before RPCharacters saves the death, so a failed save left a living character released from its lure. Lures now settle on the TLibs CharacterDeathEvent, only for the character the commitment belongs to and only while the provider still records that character as dead, so a repeat or a replay after a revival changes nothing. The DEATH end still starts no logout grace, and an ordinary death settles as before. character-required now uses the same hex red as the other errors, and its built-in fallback for older messages.yml files carries the prefix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ryanbarlow97
changed the title
github-actions
Bot
added
size:M
1 participant
Since #15, shutdown recorded every committed player as departing, and the SHUTDOWN session end did the same. Anyone not back with a ready character within
logout-grace-secondsof the stop then owed a death on their next login, for a restart they didn't choose.Shutdown now records nothing, and a SHUTDOWN session end is ignored. After the restart the empty lure fails without penalty, as it did before 0.3.0. Switching and quitting still start the grace.
The lure also settled on the DEATH session end, which RPCharacters fires before it saves the death. If that save failed, the character stayed alive but was already released from the lure. Lures now settle on the TLibs
CharacterDeathEvent, which fires only after the death is saved. It settles only the commitment of the character that died (the departed character, or the current one when there was no departure), and only while TLibs still reports that character as dead, so a repeated event or a replay after a revival changes nothing. The DEATH end itself does nothing, so it starts no logout grace. An ordinary player death settles exactly as before.character-requiredused&cwhere every other message uses#c45c5c, and its built-in fallback for oldermessages.ymlfiles had no prefix. Both now match the other messages.mvn clean verifypasses: 170 tests, coverage gate met.Docs: TF-Minecraft/Docs#171
🤖 Generated with Claude Code