Draw large settlement icons at three quarters of their old size - #42
Conversation
The 160px tier crowded the map next to the smaller settlements. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe large settlement marker size changes from 160 to 120 pixels. A test checks the icon and layout sizes, and the map scale comment now refers to the original 160-pixel icon. ChangesLarge Settlement Marker Size
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~7 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Large settlement markers render at 120px instead of 160px, while small markers remain 100px. The shared size is used across the inspected map views, with no unresolved merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
A rabbit hops past markers bright, Comment |
Summary
Test plan
vitest run app/lib/mapMarkers.test.ts app/lib/settlementMarkers.test.ts app/lib/map/chronicleGifFrame.test.tsSummary by CodeRabbit