Skip to content

fix: return one grave insurance ticket stored in a bundle - #57

Merged
Drefvelin merged 1 commit into
mainfrom
fix/grave-insurance-from-bundle
Sep 27, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
fix/grave-insurance-from-bundle

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • On death, if no loose insurance ticket can be bound, one ticket is taken out of a bundle (including a bundle inside a bundle) before the grave is saved.
  • That ticket is bound to the new grave and added back on respawn, the same way a ticket split off a stack already is. Other items in the bundle stay in the grave.

Test plan

  • mvn -P'!deploy-live' test (288 tests)
  • PR build on the dev version succeeds
  • Die with the only ticket inside a bundle, respawn, and right-click the returned ticket to recover the grave
  • A stack of tickets inside a bundle returns one bound ticket and leaves the rest in the bundle
  • A loose ticket still binds as before, and the bundle is left alone

Made with Cursor

Summary by CodeRabbit

  • New Features

    • Insurance tickets in inventory slots or bundles can now be used to insure a grave when no eligible ticket is found in the stash. One ticket is removed and returned on respawn; remaining tickets stay in place.
    • Tickets already bound to graves that still exist are skipped.
  • Documentation

    • Clarified how loose and bundled insurance tickets are handled during grave processing.

A ticket kept inside a bundle was buried with the grave, so it could not be used after respawn. Pull one ticket out, bind it, and give it back.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d22e6b73-785e-403d-bd5c-b992bce1ecc4

📥 Commits

Reviewing files that changed from the base of the PR and between 97718ab and 7c68334.

📒 Files selected for processing (5)
  • src/main/java/net/tfminecraft/rpcharacters/grave/GraveDeathListener.java
  • src/main/java/net/tfminecraft/rpcharacters/grave/GraveInsuranceExtract.java
  • src/main/java/net/tfminecraft/rpcharacters/grave/GraveInsuranceTickets.java
  • src/main/resources/graves.yml
  • src/test/java/net/tfminecraft/rpcharacters/grave/GraveInsuranceExtractTest.java
 _______________________________________________________________________________________________________
< Start when you're ready. You've been building experience all your life. Don't ignore niggling doubts. >
 -------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 3b737cb into main Sep 27, 2026
1 of 2 checks passed
@Drefvelin
Drefvelin deleted the fix/grave-insurance-from-bundle branch September 27, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant