Remove Infrastructure - #128
Merged
Merged
Conversation
Province infrastructure, effective terrain, the realm Infrastructure branch and its upkeep, track counting as infrastructure, its map export and the installation build estimate are gone. Terrain reads the raw province terrain again, and /faction construct builds straight away. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (39)
💤 Files with no reviewable changes (24)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe infrastructure system was removed from configuration, guild modifiers, province calculations, income accounting, previews and map exports. Province trade and production now use terrain-based carry. The build confirmation menu was removed, and ChangesInfrastructure system removal
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Saved financial records remain loadable, and no actionable merge-blocking issue was established. The PR is mergeable after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The checked construction paths retain leader and province-ownership controls, and removing infrastructure bonuses does not remove the remaining installation-access policy. No introduced authorization bypass was established. Downstream compatibility, rollback and exceptional recovery remain only partially verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Part of the installation-trade series (after #127). Per-province Infrastructure is removed entirely.
EffectiveTerrain,InfrastructureSources,InfrastructureSpread);infrastructureandinfrastructure_upkeepmodifiers, and the upkeep ledger line;infrastructureconfig section;InstallationBuildConfirm,InfrastructurePreview,InfrastructureMenuCopy)./faction constructbuilds straight away again, as before Estimate what a hub or installation would earn #112/Show what infrastructure earns in the menus #114.TrackProvinceCacheand the track province lookup, because the trade graph uses them to notice track changes. The mid-day track refresh runs at 300 seconds, andtrack-refresh-secondsis no longer read.infrastructurebranch entry is skipped on load.This also removes the per-province
InstallationAccesscall that CodeRabbit flagged on #127, so access is now only read inside a recalculation.Testing
mvn verifypasses locally: 2827 test cases.infrastructurebranch, and the province loader.🤖 Generated with Claude Code
Made with Cursor