Skip to content

fix: load on Paper 1.21.4 by lowering api-version - #33

Merged
Drefvelin merged 1 commit into
mainfrom
compat/paper-1.21.4
Sep 30, 2026
Merged

Drefvelin merged 1 commit into
mainfrom
compat/paper-1.21.4

Conversation

@Drefvelin

@Drefvelin Drefvelin commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Lower api-version from 1.21.10 to 1.21.4 so TLibs loads on Paper 1.21.4 servers.

Paper 1.21.4 refuses the current jar with InvalidPluginException: Unsupported API version 1.21.10. That was reported by a server running 1.21.4 and reproduced on TFMC Packtest (Paper 1.21.4-232).

VehicleFramework also needs this change; its PR is separate.

Compatibility

  • The source compiles against paper-api 1.21.4-R0.1-SNAPSHOT with no errors.
  • On Packtest (Paper 1.21.4) with the api-version patched, TLibs and VF enabled cleanly. All seven Free Pack vehicles spawned, and vehicles and a track persisted across a restart. A bot drove the gunboat with player_input.
  • On newer servers the lower label is harmless. The only Paper rewrite gated between 1.21.4 and 1.21.10 is Cow → AbstractCow (the 1.21.5 ABSTRACT_COW threshold), and this plugin doesn't reference Cow.

Test plan

  • Compile against paper-api 1.21.4
  • Load and run on Paper 1.21.4 (Packtest)
  • Load and run on TFMCDev (Paper 1.21.10) with this change: both plugins enable, and the Dev AA-turret bot test (spawn, seat GUI, mount, A/D/W/S turret input) passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Compatibility
    • The plugin now declares Minecraft API version 1.21.4 instead of 1.21.10. This updates the version listed in its plugin metadata; no other user-facing changes are included in this update.

Paper refuses plugins whose api-version is newer than the server, so
Paper 1.21.4 rejected this plugin with "Unsupported API version 1.21.10".
The source compiles against paper-api 1.21.4 and runs there unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a11eab8b-e4a4-4847-81cd-95e0cd875ae3

📥 Commits

Reviewing files that changed from the base of the PR and between 13f4e9d and 7146823.

📒 Files selected for processing (1)
  • src/main/resources/plugin.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The plugin descriptor now declares API version 1.21.4 instead of 1.21.10.

Changes

Plugin API version

Layer / File(s) Summary
Update declared API version
src/main/resources/plugin.yml
The descriptor declares API version 1.21.4 instead of 1.21.10.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 71468

The descriptor permits Paper 1.21.4, and no actionable compatibility issue is established; no merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 71468

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/main/resources/plugin.yml: The declared plugin API version changed from 1.21.10 to 1.21.4.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the main change: lowering the API version so the plugin loads on Paper 1.21.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


A rabbit checks the version line,
One number shifts into its place.
The plugin names its API,
The burrow hums a steady tune,
And carrots wait beside the file.

Comment @coderabbitai help to get the list of available commands.

@Drefvelin
Drefvelin merged commit 111646e into main Sep 30, 2026
4 checks passed
@Drefvelin
Drefvelin deleted the compat/paper-1.21.4 branch September 30, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants