Skip to content

Fix for making textarea scroll for software keyboard - #717

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
software-keyboard-fix
Oct 25, 2026
Merged

KenVanHoeylandt merged 1 commit into
mainfrom
software-keyboard-fix

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Focused text areas are kept visible above the software keyboard when it appears.
    • The screen returns to its original position when the keyboard is hidden or destroyed.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9efffe4e-d067-4a55-9f1d-5a519ba2893c
Commits

Reviewing files that changed from the base of the PR and between 7462d32 and 87ece0f.

Files selected for processing: 1
  • Modules/lvgl-module/source/devices/keyboard.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

When a textarea receives focus, the module scrolls it into view without animation before showing the software keyboard. The module clears any prior pan, finds an eligible ancestor, and shifts that ancestor upward when the textarea overlaps the keyboard. Hiding or destroying the keyboard restores the tracked ancestor’s vertical translation.

Priority: Normal

Merge Risk: Minimal · up to 87ece

The keyboard visibility change has no established remaining merge-blocking issue. It is ready for normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adjusting textarea scrolling when the software keyboard appears.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt
KenVanHoeylandt merged commit 7ab1c1f into main Oct 25, 2026
5 of 21 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the software-keyboard-fix branch October 25, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant