WiFi and e-paper improvements by KenVanHoeylandt · Pull Request #718 · TactilityProject/Tactility

KenVanHoeylandt · 2026-10-25T23:03:56Z

Summary by CodeRabbit

Improvements
- Wi-Fi network lists show a loading indicator while scanning, and refresh controls better reflect scan status.
- Wi-Fi access point settings are handled more smoothly, with controls grouped in a card and setting changes saved more reliably.
- Bluetooth peer controls are grouped in a card for a clearer settings layout.
- Displays that support slow refresh are refreshed before the shutdown or sleep screen proceeds.
Bug Fixes
- Wi-Fi scanning handles scan-start failures more clearly, preventing the loading state from persisting when a scan cannot begin.

coderabbitai · 2026-10-25T23:04:40Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 4a4b5f6a-acb6-44e5-b3a7-1dd953c43531

Commits

Reviewing files that changed from the base of the PR and between 3a10d28 and e3d7d69.

Files selected for processing: 3

Modules/wifi-module/include/wifi/wifi_settings.h
Modules/wifi-module/source/wifi_settings.cpp
Tactility/Source/app/wifiapsettings/WifiApSettings.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.

Walkthrough

The change updates Wi-Fi scan status handling and loading indicators. Access-point settings actions are queued for the app task, and their controls are grouped in a card. Bluetooth peer controls are also grouped in a card. The shutdown callback refreshes slow-refresh displays before continuing. The ideas list priorities and entries are revised.

Priority: Normal

Merge Risk: Minimal · up to e3d7d

The previously identified scan-state race and potential overwrite of saved Wi-Fi credentials are addressed at the reviewed head. No actionable merge-blocking risk remains after normal checks.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 54 functions across 11 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "WiFi and e-paper improvements" is partially related to the changeset. The changeset is mostly WiFi-focused: Wi-Fi scan refresh and failure handling, AP settings auto-connect persistence thr…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "WiFi and e-paper improvements" is partially related to the changeset. The changeset is mostly WiFi-focused: Wi-Fi scan refresh and failure handling, AP settings auto-connect persistence through a new wifi_settings_set_auto_connect function with mutex serialization, and wifi manage/AP settings UI changes. The e-paper part is only weakly represented, limited to PowerOff.cpp display refresh before shutdown. The title is overly broad and does not name the primary change. It also omits the Bluetooth peer settings card layout, the TODO list reprioritization, and the wifi settings locking. The title is not vague enough to be inconclusive, and it is not unrelated, so it does not fail.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 4

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 27e4fee7-c980-4b66-b458-6442c12922f5

Commits

Reviewing files that changed from the base of the PR and between 7ab1c1f and 7067df4.

Files selected for processing: 10

Documentation/ideas.md
Tactility/Private/Tactility/app/wifimanage/Bindings.h
Tactility/Private/Tactility/app/wifimanage/State.h
Tactility/Private/Tactility/app/wifimanage/View.h
Tactility/Source/app/btpeersettings/BtPeerSettings.cpp
Tactility/Source/app/poweroff/PowerOff.cpp
Tactility/Source/app/wifiapsettings/WifiApSettings.cpp
Tactility/Source/app/wifimanage/State.cpp
Tactility/Source/app/wifimanage/View.cpp
Tactility/Source/app/wifimanage/WifiManage.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

coderabbitai

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to GitHub limitations.

⚠️ Outside diff range comments (1)

Minor · Reload the AP settings before connecting. · WifiApSettings.cpp:210-214

Tactility/Source/app/wifiapsettings/WifiApSettings.cpp:210-214
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Reload the AP settings before connecting.

The previous callback loaded the record at click time. The new callback queues the request, then handleRequests connects with cached ctx->settings. A remembered connection from WifiConnect can update the same SSID while this view is open, so the request can use an old password or channel and fail.
Suggested fix
     if (ctx->connectRequested.exchange(false) && ctx->hasSettings) {
-        connectToAp(ctx->settings);
+        WifiApSettings settings {};
+        if (wifi_settings_load(ctx->ssid.c_str(), &settings) == ERROR_NONE) {
+            connectToAp(settings);
+        }
     }

Review info

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a9064d0b-b2a8-42df-b3fd-edfc278a3025

Commits

Reviewing files that changed from the base of the PR and between 7067df4 and 3a10d28.

Files selected for processing: 5

Tactility/Private/Tactility/app/wifimanage/State.h
Tactility/Source/app/wifiapsettings/WifiApSettings.cpp
Tactility/Source/app/wifimanage/State.cpp
Tactility/Source/app/wifimanage/View.cpp
Tactility/Source/app/wifimanage/WifiManage.cpp

Files skipped from review as they are similar to previous changes: 3

Tactility/Source/app/wifimanage/WifiManage.cpp
Tactility/Private/Tactility/app/wifimanage/State.h
Tactility/Source/app/wifimanage/State.cpp

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

KenVanHoeylandt added 3 commits October 25, 2026 23:17

Fix crash

8e75be1

WiFi and BT UX improvements

43922ce

Refresh before power off

7067df4

KenVanHoeylandt changed the title ~~WiFi and e~~ WiFi and e-paper improvements Oct 25, 2026

coderabbitai Bot reviewed Oct 25, 2026

View reviewed changes

Comment thread Tactility/Source/app/wifiapsettings/WifiApSettings.cpp Outdated

Comment thread Tactility/Source/app/wifiapsettings/WifiApSettings.cpp Outdated

Comment thread Tactility/Source/app/wifimanage/View.cpp

Comment thread Tactility/Source/app/wifimanage/View.cpp

Fixes

3a10d28

coderabbitai Bot reviewed Oct 25, 2026

View reviewed changes

Comment thread Tactility/Source/app/wifiapsettings/WifiApSettings.cpp Outdated

Comment thread Tactility/Source/app/wifiapsettings/WifiApSettings.cpp

Fixes

e3d7d69

KenVanHoeylandt merged commit e42c9aa into main Oct 26, 2026
78 checks passed

KenVanHoeylandt deleted the develop branch October 26, 2026 07:01

Navigation Menu

Repository navigation

WiFi and e-paper improvements - #718

WiFi and e-paper improvements#718
KenVanHoeylandt merged 5 commits into
mainfrom
develop

KenVanHoeylandt commented Oct 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

KenVanHoeylandt commented Oct 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

KenVanHoeylandt commented Oct 25, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading