Skip to content

elf_loader 2.0.0, CL-32 display support and more - #719

Merged
KenVanHoeylandt merged 5 commits into
mainfrom
develop
Oct 27, 2026
Merged

KenVanHoeylandt merged 5 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • CL32 v4 now detects whether the hardware has a reflective LCD or an e-paper display and initializes the available display automatically.
    • The device information now reflects support for either display type.
  • Improvements
    • The startup banner has updated artwork and shows the version and target together on one line.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The change adds CL32 v4 detection for SSD16xx e-paper and ST7305 reflective displays, with module startup and teardown hooks. It updates ELF loader dependency and API usage, revises the startup banner, and edits the project ideas list.

Priority: Normal

Merge Risk: Moderate · up to 386be

CL32 v4 display detection can pick the wrong driver after a transient SPI setup failure and then never retry. A failed display stop during module teardown can leave the display registered but untracked. These are narrow failure paths with a bounded blast radius, but they should be fixed before merge. The persistent display state also should move out of internal RAM.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surv… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names two real changes in the changeset: the elf_loader dependency bump from 1.3.3 to 2.0.0 in Tactility/idf_component.yml, and CL32 v4 display support (display detection, SSD16xx/ST7305 sel…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names two real changes in the changeset: the elf_loader dependency bump from 1.3.3 to 2.0.0 in Tactility/idf_component.yml, and CL32 v4 display support (display detection, SSD16xx/ST7305 selection, and module hooks). The title also says "and more," which covers the logo, ideas.md, device tree, and ELF cache changes. The title is concise and identifies the main changes. It does not describe the changes in detail, which is acceptable.

Full details: Docstring Coverage

Explanation

Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 13 functions across 5 files. (7 skipped: 7 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a25ad756-8655-491a-bbaf-27cfa6458c89
Commits

Reviewing files that changed from the base of the PR and between e42c9aa and 386be93.

Files selected for processing: 12
  • Buildscripts/logo.cmake
  • Devices/cl32-v04/CMakeLists.txt
  • Devices/cl32-v04/cl32-v04.dts
  • Devices/cl32-v04/device.properties
  • Devices/cl32-v04/module.yaml
  • Devices/cl32-v04/source/cl32_v4_display.cpp
  • Devices/cl32-v04/source/cl32_v4_display.h
  • Devices/cl32-v04/source/module.cpp
  • Documentation/ideas.md
  • Modules/app-esp32-module/source/app_esp32_loader_service.cpp
  • Modules/app-esp32-module/source/elf_cache.cpp
  • Tactility/idf_component.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Comment thread Devices/cl32-v04/source/cl32_v4_display.cpp
Comment thread Devices/cl32-v04/source/cl32_v4_display.cpp
Comment thread Devices/cl32-v04/source/cl32_v4_display.cpp
@KenVanHoeylandt
KenVanHoeylandt merged commit ed6759a into main Oct 27, 2026
78 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch October 27, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant