Skip to content

Override system files for a device - #720

Merged
KenVanHoeylandt merged 1 commit into
mainfrom
boot-logo-override
Oct 27, 2026
Merged

KenVanHoeylandt merged 1 commit into
mainfrom
boot-logo-override

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Device-specific system assets can now replace default assets when they use the same relative path. This allows devices to provide tailored versions of existing system files while retaining the defaults for files they do not override. Multiple overlay folders are supported, with later folders taking precedence when paths match. Nonexistent overlay folders are ignored.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c74e86f4-fc66-42c9-aebb-13d20c44357d
Commits

Reviewing files that changed from the base of the PR and between ed6759a and 8fd315b.

Files selected for processing: 3
  • .claude/rules/key-conventions.md
  • Buildscripts/generate-assets.py
  • Tactility/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The asset generator now accepts optional overlay folders after the required asset and output folders. For each relative path, it uses the file from the last supplied folder that contains that path, and skips nonexistent overlay folders. The build command passes the device’s system/ directory as an overlay. Documentation describes this replacement behavior.

Priority: Normal

Merge Risk: Minimal · up to 8fd31

The overlay change is mergeable based on the verified implementation and documented behavior.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: allowing device-specific overrides for system files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt
KenVanHoeylandt merged commit 0d68d6b into main Oct 27, 2026
15 of 73 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the boot-logo-override branch October 27, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant