[AdaSzi]

• Pass the certificate text to http_download_start (Tactility #701)
• No file work on the LVGL thread: callbacks ask the app task to save, groups and downloads are read there
• Pass search and the Next passes list run on the app task, the map shows at once
• The last device location is saved and used at start, so the automatic selection no longer changes after a few seconds

Summary by CodeRabbit

• New Features

  • The tracker now uses the last known device location until a new location fix arrives.
  • Added clear status messages while pass searches and the Next passes list are being prepared.

• Bug Fixes

  • Pass information updates when satellite or observer data changes, helping prevent outdated results from being displayed.
  • Catalog results are shown only for the group or search currently selected, with saved data available as a fallback when downloads fail.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 42 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: acbb1605-d050-4054-a90b-aeef8a788d83

📥 Commits

Reviewing files that changed from the base of the PR and between 35304cd and cda4638.

📒 Files selected for processing: 1

• Apps/SatelliteTracker/main/Source/MapView.cpp

📝 Walkthrough

The tracker now saves the last device location and uses task work for persistence, catalog loading, and pass searches. Download results are parsed before handlers receive them. Pass calculations run outside the model lock and apply results only when observer and orbit versions remain current. The Next passes view uses a cached list and shows a loading message while it is built. The downloader now loads its certificate into memory.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 35304

While passes are being recalculated after startup or a location change, the map can show misleading pass text for a few seconds. The text corrects itself afterwards, so the change is mergeable, ideally after fixing these display issues.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 12.82% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 78 functions across 13 files. (2 skipped:…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the main changes: support for new firmware and faster startup. It is concise and specific.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 12.82% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 78 functions across 13 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 2

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 25458be1-4f84-46ec-aabe-2f0b562e7c95

📥 Commits

Reviewing files that changed from the base of the PR and between 2c87d2f and 35304cd.

📒 Files selected for processing: 15

• Apps/SatelliteTracker/README.md
• Apps/SatelliteTracker/main/Source/Downloads.cpp
• Apps/SatelliteTracker/main/Source/Downloads.h
• Apps/SatelliteTracker/main/Source/MapView.cpp
• Apps/SatelliteTracker/main/Source/PassesView.cpp
• Apps/SatelliteTracker/main/Source/SatelliteTracker.cpp
• Apps/SatelliteTracker/main/Source/SatelliteTracker.h
• Apps/SatelliteTracker/main/Source/SatellitesView.cpp
• Apps/SatelliteTracker/main/Source/SettingsView.cpp
• Apps/SatelliteTracker/main/Source/Storage.cpp
• Apps/SatelliteTracker/main/Source/Storage.h
• Apps/SatelliteTracker/main/Source/TrackerModel.cpp
• Apps/SatelliteTracker/main/Source/TrackerModel.h
• Apps/SatelliteTracker/main/Source/main.cpp
• Apps/SatelliteTracker/manifest.properties

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

[KenVanHoeylandt]

Thanks a lot!