Skip to content

Fix MediaKeys, add WebServer, update CI - #59

Merged
KenVanHoeylandt merged 6 commits into
mainfrom
develop
Oct 21, 2026
Merged

KenVanHoeylandt merged 6 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added a Web Server app with dashboard, file management, app installation/launching, Wi‑Fi modes, authentication, and configurable settings.
    • Added project-generation prompts for GUI, terminal, and module projects.
    • Added improved SDK version validation, installation checks, and update handling.
  • Bug Fixes

    • Improved Bluetooth and HID operation reliability in MediaKeys.
    • Added safer web-server authentication, uploads, filesystem handling, and path validation.
  • Documentation

    • Added comprehensive Web Server documentation.
  • Chores

    • Added build-cache support for faster builds.
    • Replaced the Windows launcher with a PowerShell equivalent.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

This PR adds a Web Server module with settings, HTTP endpoints, a settings app, and a browser dashboard. It moves MediaKeys Bluetooth operations to a worker queue. It adds compiler-cache restoration and saving to the build workflow. It also updates tt.py with project generation and SDK preparation changes, and replaces the Windows command launcher with a PowerShell launcher.

Priority: ⚪ Pending latest changes

Merge Risk: 🟡 Moderate · up to d27c6

The new build workflow is likely to fail on a duplicate artifact name. The Web Server can show credentials that it rejects and exposes state-changing endpoints to cross-origin requests when authentication is off. Fix these before merging; the remaining items are smaller edge-case defects.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 24.82% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 141 functions across 14 files. (13 skippe… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title accurately identifies the main changes: the MediaKeys fix, the new WebServer, and CI updates. It is concise and specific, although it does not mention the tt.py update.
Full details: Docstring Coverage

Explanation

Docstring coverage is 24.82% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 141 functions across 14 files. (13 skipped: 13 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 2
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 13


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6db5ef3b-c812-449a-82c0-b11b1852f8ba
📥 Commits

Reviewing files that changed from the base of the PR and between 13c4350 and d27c605.

⛔ Files ignored due to path filters: 1
  • Apps/WebServer/assets/favicon.png is excluded by !**/*.png
📒 Files selected for processing: 28
  • .github/actions/build-app/action.yml
  • .github/workflows/main.yml
  • .gitignore
  • Apps/MediaKeys/main/Source/MediaKeys.cpp
  • Apps/MediaKeys/main/Source/MediaKeys.h
  • Apps/WebServer/CMakeLists.txt
  • Apps/WebServer/README.md
  • Apps/WebServer/assets/dashboard.html
  • Apps/WebServer/assets/version.json
  • Apps/WebServer/common/webserver.h
  • Apps/WebServer/manifest.properties
  • Apps/WebServer/webserver-module/CMakeLists.txt
  • Apps/WebServer/webserver-module/main/CMakeLists.txt
  • Apps/WebServer/webserver-module/main/Source/Handlers.cpp
  • Apps/WebServer/webserver-module/main/Source/Handlers.h
  • Apps/WebServer/webserver-module/main/Source/Settings.cpp
  • Apps/WebServer/webserver-module/main/Source/Settings.h
  • Apps/WebServer/webserver-module/main/Source/Util.cpp
  • Apps/WebServer/webserver-module/main/Source/Util.h
  • Apps/WebServer/webserver-module/main/Source/WebServer.cpp
  • Apps/WebServer/webserver-module/main/Source/WebServer.h
  • Apps/WebServer/webserver-module/main/Source/module.cpp
  • Apps/WebServer/webserver/CMakeLists.txt
  • Apps/WebServer/webserver/main/CMakeLists.txt
  • Apps/WebServer/webserver/main/Source/main.cpp
  • tt.cmd
  • tt.ps1
  • tt.py
💤 Files with no reviewable changes: 1
  • tt.cmd

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread .github/workflows/main.yml
Comment thread Apps/MediaKeys/main/Source/MediaKeys.cpp
Comment thread Apps/MediaKeys/main/Source/MediaKeys.cpp Outdated
Comment thread Apps/WebServer/webserver-module/main/Source/Handlers.cpp
Comment thread Apps/WebServer/webserver-module/main/Source/Handlers.cpp Outdated
Comment thread Apps/WebServer/webserver-module/main/Source/Settings.cpp Outdated
Comment thread Apps/WebServer/webserver-module/main/Source/Util.cpp
Comment thread Apps/WebServer/webserver/main/Source/main.cpp
Comment thread tt.ps1
Comment thread tt.py
@KenVanHoeylandt KenVanHoeylandt changed the title Develop Fix MediaKeys, add WebServer, update CI Oct 21, 2026
@KenVanHoeylandt
KenVanHoeylandt merged commit fab84d4 into main Oct 21, 2026
32 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch October 21, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant