fix: correct generateDynamicNodeCallbacks return type

[camielvs]

Part of B3 of #2626.

The bug

generateDynamicNodeCallbacks binds the node & task ids into each NodeCallbacks entry, so what it returns takes one fewer argument than what it received. It declared its return type as NodeCallbacks anyway — the un-bound shape — so every callback it handed back was typed as still needing an ids argument that the wrapper already supplies.

Nothing caught this because the only caller, createTaskNode, launders the result through as Node.

The fix

Return TaskNodeCallbacks, the shape actually produced. Once the types line up, the reflective Object.fromEntries construction is no longer needed to satisfy the compiler, so the object is built explicitly. That removes:

• the ExcludeNodeAndTaskId helper type
• an ...args: any[] spread
• all three as casts

and turns a missing or misordered argument into a compile error instead of something the casts absorb.

Behaviour deltas

Two, both verified unreachable in production:

Delta	Why it can't bite
No-callbacks branch returns DEFAULT_TASK_NODE_CALLBACKS instead of {} as NodeCallbacks, so consumers gating on callback truthiness (TaskDetails/Actions.tsx:64,74,90) now see no-ops rather than undefined	FlowCanvas.tsx:394-404 always passes nodeCallbacks; the branch is never taken
The ids object is built once and shared by all seven wrappers rather than rebuilt per call	All seven useNodeCallbacks implementations only read ids.taskId/ids.nodeId; none mutates it

TaskNodeCallbacks is exported for the annotation. CallbackWithIds is un-exported — it's used only inside src/types/taskNode.ts, and Knip fails CI on an export consumed solely within its own file.

Tests

Adds generateDynamicNodeCallbacks.test.ts (6 tests) — the wrapper had no coverage. It pins id derivation, id injection ahead of caller args, undefined trailing args, laziness, and the no-callbacks branch.

Reverting only the type change makes the new test file fail to compile with 8 arity errors, so the test genuinely depends on the fix rather than merely accompanying it.

Verification

typecheck · lint · knip · prettier clean; full suite 192 files / 1972 tests passing.

Scope is v1-only: NodeCallbacks appears in 8 files, all under the v1 canvas. v2's single edge to this area is a type-only TaskNodeContextType import.

Left deliberately out of scope: TaskNodeProvider.tsx:51 declares a third, structurally different local TaskNodeCallbacks (adds setCollapsed, makes four callbacks optional). Collapsing it is a separate change.

🤖 Generated with Claude Code

[github-actions]

🎩 Preview

A preview build has been created at: fix/dynamic-node-callbacks-return-type/b55c868