Bound orchestrator storage waits - #330
Open
morgan-wowk wants to merge 1 commit into
Open
Conversation
Add a timeout-aware GCS storage provider using google-cloud-storage's official per-call timeout parameter, wire GCS launchers through it, and bound the orchestrator retry helper with a configurable wall-clock deadline. Co-authored-by: Morgan Wowk <morgan.wowk@shopify.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| timeout=self._request_timeout, | ||
| ) | ||
|
|
||
| def _download_from_uri(self, source_uri: str, destination_path: str): |
Collaborator
Author
|
Paired consumer change (opts into the new timeout-bounded provider): Shopify/oasis-backend#507 → https://github.com/Shopify/oasis-backend/pull/507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GoogleCloudStorageProviderWithTimeout— a GCSStorageProviderthat passes an explicit per-requesttimeout=to every GCS call (upload / download /exists/get_info/list_blobs). The timeout is configurable viaTANGLE_GCS_REQUEST_TIMEOUT_SECONDS(default60s).kubernetes_launchers,google_kubernetes_launchers) to construct and use it.TANGLE_ORCHESTRATOR_RETRY_DEADLINE_SECONDS, default180s) via a newRetryDeadlineExceededError, so retries can no longer spin unbounded.Why / system impact
Before: GCS calls relied on the client's default (effectively unbounded) timeout. A single hung GCS request could wedge the orchestrator's poll loop indefinitely, stalling all execution processing.
After: every storage wait is bounded. A slow or stuck GCS request now fails fast and is retried within a deadline instead of blocking the loop, so one bad request degrades a single execution rather than the whole orchestrator.
Paired change
A consumer opts in by constructing this provider instead of the upstream
GoogleCloudStorageProvider. The paired consumer change is linked in a follow-up comment.