⚡ Bolt: optimize formatted string concatenations with write! macro - #125
Conversation
This commit optimizes string generation in tight loops across the codebase (diagnostics, profiler, debugger, etc.) by replacing `.push_str(&format!(...))` with the `write!` macro using `std::fmt::Write`. This prevents the intermediate memory allocation created by the `format!` macro. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Replaced instances of
.push_str(&format!(...))with directwrite!(..., ...)macro calls viastd::fmt::Writeacross several modules (CLI, diagnostics, profiler, runtime builtins, and VM debugger).🎯 Why: Using
format!inside a loop creates temporaryStringallocations that are immediately appended and discarded. This puts unnecessary pressure on the allocator. Usingwrite!directly to a pre-allocatedStringbuffer (or an existing formatter) completely eliminates these intermediate allocations. This was previously identified as a bottleneck in string rendering contexts.📊 Impact: Reduces memory allocations inside diagnostic rendering, profiler string generation, VM trace outputs, and AST/IR disassembly loops. Expected faster output formatting operations with lower peak memory footprint.
🔬 Measurement: Verified correctness using
cargo test --workspacetests. No regressions in functionality, with potentially faster string builder execution times.PR created automatically by Jules for task 8436430878582263470 started by @Tcode-Motion