Skip to content

⚡ Bolt: Remove push_str(&format!(...)) allocations - #126

Merged
Tcode-Motion merged 1 commit into
mainfrom
bolt-optimization/remove-push-str-format-3653897259569321771
Sep 12, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
bolt-optimization/remove-push-str-format-3653897259569321771

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

💡 What: Replaced inefficient push_str(&format!(...)) calls with write!(...) directly onto string buffers across several Rust modules. Imported std::fmt::Write trait where necessary.
🎯 Why: The push_str(&format!(...)) anti-pattern allocates an intermediate String internally on each iteration, causing significant overhead in formatting strings, especially when done in loops (like diagnostic generation, documentation rendering, and bytecode tracing). Writing directly to the buffer bypasses this intermediate heap allocation completely.
📊 Impact: Reduces redundant string allocations across the compiler CLI, runtime built-ins, bytecode disassembler, and debugger.
🔬 Measurement: Benchmarks focusing on the diagnostics rendering and trace execution paths should reflect reduced peak memory consumption and slightly faster execution speeds. This optimization is easily testable via cargo test --workspace ensuring zero behavioral regressions.


PR created automatically by Jules for task 3653897259569321771 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 12, 2026 04:56
@Tcode-Motion
Tcode-Motion merged commit 789b55f into main Sep 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant