Skip to content

⚡ Bolt: Optimize string allocation in BytecodeDisassembler - #129

Merged
Tcode-Motion merged 1 commit into
mainfrom
bolt/bytecode-disassembler-optimization-16527750496915012933
Sep 14, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
bolt/bytecode-disassembler-optimization-16527750496915012933

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

💡 What:
Replaced format! calls with direct write! macro invocations inside the BytecodeDisassembler::disassemble_function loop in compiler/bytecode/src/disassembler.rs.

🎯 Why:
The previous code was allocating two intermediate strings per instruction (op_str and line) only to append them to the main output string. This was a source of unnecessary heap allocations on the hot path for tracing and debugging.

📊 Impact:
Reduces memory allocation overhead significantly when disassembling large modules by eliminating intermediate string allocations in the main rendering loop.

🔬 Measurement:
Run cargo test --package techscript_bytecode to verify that the disassembler format output remains exactly the same.


PR created automatically by Jules for task 16527750496915012933 started by @Tcode-Motion

Replaced intermediate `format!` allocations with direct `write!` invocations inside the `BytecodeDisassembler`'s formatting loop, reducing unnecessary heap allocations.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 14, 2026 05:31
@Tcode-Motion
Tcode-Motion merged commit 9b8d44c into main Sep 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant