fix(stdlib): prevent panic on port binding in std.web - #132
Tcode-Motion wants to merge 1 commit into
Conversation
- Replaced `unwrap()` calls on `tiny_http::Server::http` with matching the `Result`. - When binding fails (e.g. port already in use), it now returns a `RuntimeError` instead of crashing the VM with a panic. - `SERVER_RUNNING` is correctly set back to `false` on failure. - Updated `stdlib_tests.rs` to expect errors instead of panics for these conditions. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Replaced the panic-inducing
unwrap()calls when binding to a port in thestd.webstandard library module. Now, it returns a properRuntimeErrorand resets the running state if the binding fails, improving stability and avoiding crashes. Updated relevant tests.PR created automatically by Jules for task 18201028135435300803 started by @Tcode-Motion