Skip to content

🧹 [Remove unnecessary allow(dead_code) in lexer] - #138

Merged
Tcode-Motion merged 1 commit into
mainfrom
fix-lexer-dead-code-allow-497134182478054133
Sep 15, 2026
Merged

Tcode-Motion merged 1 commit into
mainfrom
fix-lexer-dead-code-allow-497134182478054133

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Removed the unnecessary #[allow(dead_code)] attribute from the LogosToken enum in compiler/lexer/src/lib.rs. Also removed the empty line left behind to prevent clippy::empty_line_after_outer_attr.

💡 Why: The attribute was masking the fact that the code is actively used (and generated correctly by logos-derive). Removing it improves accuracy and code health, keeping standard compiler checks intact to properly catch actual dead code in the future.

✅ Verification: Verified via cargo clippy --workspace --all-targets that the dead_code warnings don't actually trigger (meaning the code isn't dead). Also ran cargo test --workspace to ensure all functionality is preserved.

✨ Result: Improved codebase maintainability by keeping the compiler checks accurate and removing unneeded override attributes.


PR created automatically by Jules for task 497134182478054133 started by @Tcode-Motion

Removed `#[allow(dead_code)]` from `LogosToken` enum in `compiler/lexer/src/lib.rs` since the tokens are fully generated by `logos-derive` and matched in `Lexer::map_logos_token`, so they are not actually dead code. Also fixed the resulting empty line to avoid `clippy::empty_line_after_outer_attr` warnings.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 15, 2026 08:19
@Tcode-Motion
Tcode-Motion merged commit 7169650 into main Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant